From: David Miller <davem@davemloft.net>
To: Paul.Chavent@onera.fr
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] packet: tx_ring: allow the user to choose tx data offset
Date: Wed, 31 Oct 2012 13:14:34 -0400 (EDT) [thread overview]
Message-ID: <20121031.131434.910561089094397853.davem@davemloft.net> (raw)
In-Reply-To: <1350889014-2975-1-git-send-email-paul.chavent@onera.fr>
From: Paul Chavent <Paul.Chavent@onera.fr>
Date: Mon, 22 Oct 2012 08:56:54 +0200
> + if (unlikely((off < off_min) || (off_max < off))) {
> + pr_err("payload offset (%d) out of range [%d;%d]\n",
> + off, off_min, off_max);
> + return -EINVAL;
> + }
Users should not be able to spam the kernel log with error messages
by simply make setsockopt() calls.
This error log is inappropriate.
> @@ -110,6 +110,7 @@ struct packet_sock {
> unsigned int tp_reserve;
> unsigned int tp_loss:1;
> unsigned int tp_tstamp;
> + unsigned int tp_tx_has_off:1;
> struct packet_type prot_hook ____cacheline_aligned_in_smp;
> };
Please put the new bit field next to other existing bit fields so that
there is less wasted space in the struct.
next prev parent reply other threads:[~2012-10-31 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 6:56 [PATCH net-next v2] packet: tx_ring: allow the user to choose tx data offset Paul Chavent
2012-10-31 17:14 ` David Miller [this message]
2012-10-31 21:22 ` Paul Chavent
2012-11-01 14:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031.131434.910561089094397853.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Paul.Chavent@onera.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).