From: David Miller <davem@davemloft.net>
To: robherring2@gmail.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, rob.herring@calxeda.com
Subject: Re: [PATCH v2 RESEND 3/6] net: calxedaxgmac: use relaxed i/o accessors in rx and tx paths
Date: Thu, 01 Nov 2012 11:21:41 -0400 (EDT) [thread overview]
Message-ID: <20121101.112141.2093388998181270335.davem@davemloft.net> (raw)
In-Reply-To: <1351766464-27354-4-git-send-email-robherring2@gmail.com>
From: Rob Herring <robherring2@gmail.com>
Date: Thu, 1 Nov 2012 05:41:01 -0500
> From: Rob Herring <rob.herring@calxeda.com>
>
> The standard readl/writel accessors involve a spinlock and cache sync
> operation on ARM platforms with an outer cache. Only DMA triggering
> accesses need this, so use the relaxed variants instead.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> ---
> drivers/net/ethernet/calxeda/Kconfig | 2 +-
> drivers/net/ethernet/calxeda/xgmac.c | 12 ++++++------
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/calxeda/Kconfig b/drivers/net/ethernet/calxeda/Kconfig
> index aba435c..6a4ddf6 100644
> --- a/drivers/net/ethernet/calxeda/Kconfig
> +++ b/drivers/net/ethernet/calxeda/Kconfig
> @@ -1,6 +1,6 @@
> config NET_CALXEDA_XGMAC
> tristate "Calxeda 1G/10G XGMAC Ethernet driver"
> - depends on HAS_IOMEM
> + depends on HAS_IOMEM && ARM
> select CRC32
> help
> This is the driver for the XGMAC Ethernet IP block found on Calxeda
This is a regression. Now I can't built test this driver on x86
or sparc.
I'm not applying this series. You can argue until the cows come home
about why you absolutley have to add this restriction, but I simply
don't care, this issue is too important to me.
next prev parent reply other threads:[~2012-11-01 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 10:40 [PATCH v2 RESEND 0/6] Calxeda xgmac performance fixes Rob Herring
2012-11-01 10:40 ` [PATCH v2 RESEND 1/6] net: calxedaxgmac: enable operate on 2nd frame mode Rob Herring
2012-11-01 10:41 ` [PATCH v2 RESEND 2/6] net: calxedaxgmac: remove explicit rx dma buffer polling Rob Herring
2012-11-01 10:41 ` [PATCH v2 RESEND 3/6] net: calxedaxgmac: use relaxed i/o accessors in rx and tx paths Rob Herring
2012-11-01 15:21 ` David Miller [this message]
2012-11-01 15:57 ` Rob Herring
2012-11-01 16:05 ` David Miller
2012-11-01 10:41 ` [PATCH v2 RESEND 4/6] net: calxedaxgmac: drop some unnecessary register writes Rob Herring
2012-11-01 10:41 ` [PATCH v2 RESEND 5/6] net: calxedaxgmac: rework transmit ring handling Rob Herring
2012-11-01 10:41 ` [PATCH v2 RESEND 6/6] net: calxedaxgmac: ip align receive buffers Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101.112141.2093388998181270335.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).