From: David Miller <davem@davemloft.net>
To: sony.chacko@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH V5 04/22] qlcnic: modify PCI and register access routines
Date: Fri, 02 Nov 2012 21:27:32 -0400 (EDT) [thread overview]
Message-ID: <20121102.212732.478167267058337431.davem@davemloft.net> (raw)
In-Reply-To: <1351818414-25197-5-git-send-email-sony.chacko@qlogic.com>
From: Sony Chacko <sony.chacko@qlogic.com>
Date: Thu, 1 Nov 2012 21:06:36 -0400
> From: Sony Chacko <sony.chacko@qlogic.com>
>
> Refactor 82xx driver to support new adapter - Qlogic 83XX CNA
> Update PCI and hardware access routines
>
> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko@qlogic.com>
This removes the only user of qlcnic_check_vf() but leaves the
definition around, dangling, and creating a build warning:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:454:1: warning: ‘qlcnic_check_vf’ defined but not used [-Wunused-function]
Before you even bother sending this series yet another time, I want
you to do what I'm going to do with your patches anyways, which is
apply them one by one and verify that at each and every patch there
are no build failures or new warnings introduced.
My patience with you guys is wearing thin, and after being without
power or heat for 5 days I'm really grumpy. So you better take
your time and make sure this thing is perfect before you even
think about posting it again.
Thanks.
next prev parent reply other threads:[~2012-11-03 1:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 1:06 [PATCH V5 0/22] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-11-02 1:06 ` [PATCH V5 01/22] qlcnic: move HW specific data to seperate structure Sony Chacko
2012-11-02 1:06 ` [PATCH V5 02/22] qlcnic: create seperate file for data path routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 03/22] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-11-02 1:06 ` [PATCH V5 04/22] qlcnic: modify PCI and register access routines Sony Chacko
2012-11-03 1:27 ` David Miller [this message]
2012-11-02 1:06 ` [PATCH V5 05/22] qlcnic: change driver hardware interface mechanism Sony Chacko
2012-11-02 1:06 ` [PATCH V5 06/22] qlcnic: macros for common register access Sony Chacko
2012-11-02 1:06 ` [PATCH V5 07/22] qlcnic: update driver resource allocation routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 08/22] qlcnic: get board name API Sony Chacko
2012-11-02 1:06 ` [PATCH V5 09/22] qlcnic: update NIC partition interface routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 10/22] qlcnic: cleanup unused register interfaces Sony Chacko
2012-11-02 1:06 ` [PATCH V5 11/22] qlcnic: rename module params with module_param_named Sony Chacko
2012-11-02 1:06 ` [PATCH V5 12/22] qlcnic: 83xx memory map and HW access routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 13/22] qlcnic: 83xx data path routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 14/22] qlcnic: 83xx base driver Sony Chacko
2012-11-02 1:06 ` [PATCH V5 15/22] qlcnic: create seperate file for sysfs routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 16/22] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 18/22] qlcnic: flash template based firmware reset recovery Sony Chacko
2012-11-02 1:06 ` [PATCH V5 19/22] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-11-02 1:06 ` [PATCH V5 20/22] qlcnic: common register dump utility Sony Chacko
2012-11-02 1:06 ` [PATCH V5] qlcnic: 83xx ethtool interface routines Sony Chacko
2012-11-02 1:06 ` [PATCH V5 22/22] qlcnic: update driver version - 5.1.30 Sony Chacko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102.212732.478167267058337431.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).