From: David Miller <davem@davemloft.net>
To: john.r.fastabend@intel.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH net-next] net: Fix continued iteration in rtnl_bridge_getlink()
Date: Fri, 02 Nov 2012 21:54:04 -0400 (EDT) [thread overview]
Message-ID: <20121102.215404.1294793435449363791.davem@davemloft.net> (raw)
In-Reply-To: <5094766B.1000407@intel.com>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Fri, 02 Nov 2012 18:42:03 -0700
> On 11/2/2012 3:56 PM, Ben Hutchings wrote:
>> Commit e5a55a898720096f43bc24938f8875c0a1b34cd7 ('net: create generic
>> bridge ops') broke the handling of a non-zero starting index in
>> rtnl_bridge_getlink() (based on the old br_dump_ifinfo()).
>>
>> When the starting index is non-zero, we need to increment the current
>> index for each entry that we are skipping. Also, we need to check the
>> index before both cases, since we may previously have stopped
>> iteration between getting information about a device from its master
>> and from itself.
>>
>> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>> ---
>
> I needed to be testing with more interfaces. Its clearly broke
> with >41 veth devices. This patch fixes it thanks a lot Ben!
>
> Tested-by: John Fastabend <john.r.fastabend@intel.com>
Applied, thanks everyone.
prev parent reply other threads:[~2012-11-03 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 22:56 [PATCH net-next] net: Fix continued iteration in rtnl_bridge_getlink() Ben Hutchings
2012-11-02 23:04 ` Ben Hutchings
2012-11-03 1:42 ` John Fastabend
2012-11-03 1:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102.215404.1294793435449363791.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox