netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock
@ 2012-10-31  4:24 Frank Li
  2012-11-01 16:30 ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Frank Li @ 2012-10-31  4:24 UTC (permalink / raw)
  To: lznua, richardcochran, shawn.guo, linux-arm-kernel, netdev, davem
  Cc: Frank Li

This patch series enables hardware time stamping and a PTP hardware clock
for mx6 ENET controller.

Frank Li (4):
  net: fec: move fec_enet_private to header file
  ARM: dts: imx6q: Add ENET PTP clock pin and clock source
  ARM: imx6q: Set enet tx reference clk from anatop to support 1588
  FEC: Add time stamping code and a PTP hardware clock

 arch/arm/boot/dts/imx6q.dtsi             |    5 +-
 arch/arm/mach-imx/mach-imx6q.c           |   12 +
 drivers/net/ethernet/freescale/Kconfig   |    9 +
 drivers/net/ethernet/freescale/Makefile  |    1 +
 drivers/net/ethernet/freescale/fec.c     |  161 +++++++------
 drivers/net/ethernet/freescale/fec.h     |  119 +++++++++
 drivers/net/ethernet/freescale/fec_ptp.c |  386 ++++++++++++++++++++++++++++++
 7 files changed, 617 insertions(+), 76 deletions(-)
 create mode 100644 drivers/net/ethernet/freescale/fec_ptp.c

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock
  2012-10-31  4:24 [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock Frank Li
@ 2012-11-01 16:30 ` David Miller
  2012-11-02  2:36   ` Frank Li
  0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-11-01 16:30 UTC (permalink / raw)
  To: Frank.Li; +Cc: lznua, richardcochran, shawn.guo, linux-arm-kernel, netdev

From: Frank Li <Frank.Li@freescale.com>
Date: Wed, 31 Oct 2012 12:24:40 +0800

> This patch series enables hardware time stamping and a PTP hardware clock
> for mx6 ENET controller.
> 
> Frank Li (4):
>   net: fec: move fec_enet_private to header file
>   ARM: dts: imx6q: Add ENET PTP clock pin and clock source
>   ARM: imx6q: Set enet tx reference clk from anatop to support 1588
>   FEC: Add time stamping code and a PTP hardware clock

All applied to net-next.

Please make sure your changes are in sync with Ben's PTP/PPS
Kconfig changes of today, and send me any changes if necessary.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock
  2012-11-01 16:30 ` David Miller
@ 2012-11-02  2:36   ` Frank Li
  2012-11-02  8:43     ` Richard Cochran
  0 siblings, 1 reply; 6+ messages in thread
From: Frank Li @ 2012-11-02  2:36 UTC (permalink / raw)
  To: David Miller
  Cc: Frank.Li, lznuaa, richardcochran, shawn.guo, linux-arm-kernel,
	netdev

>
> All applied to net-next.
>
> Please make sure your changes are in sync with Ben's PTP/PPS
> Kconfig changes of today, and send me any changes if necessary.
>

Thank you very much.
I checked Ben's patch, which not affect FEC.

best regards
Frank Li

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock
  2012-11-02  2:36   ` Frank Li
@ 2012-11-02  8:43     ` Richard Cochran
  2012-11-02 23:25       ` Ben Hutchings
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Cochran @ 2012-11-02  8:43 UTC (permalink / raw)
  To: Frank Li; +Cc: David Miller, Frank.Li, shawn.guo, linux-arm-kernel, netdev

On Fri, Nov 02, 2012 at 10:36:09AM +0800, Frank Li wrote:
> >
> > All applied to net-next.
> >
> > Please make sure your changes are in sync with Ben's PTP/PPS
> > Kconfig changes of today, and send me any changes if necessary.
> >
> 
> Thank you very much.
> I checked Ben's patch, which not affect FEC.

Maybe just remove the Kconfig line "select PPS".

Thanks,
Richard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock
  2012-11-02  8:43     ` Richard Cochran
@ 2012-11-02 23:25       ` Ben Hutchings
  2012-11-05 11:23         ` Frank Li
  0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2012-11-02 23:25 UTC (permalink / raw)
  To: Richard Cochran, Frank Li
  Cc: David Miller, Frank.Li, shawn.guo, linux-arm-kernel, netdev

On Fri, 2012-11-02 at 09:43 +0100, Richard Cochran wrote:
> On Fri, Nov 02, 2012 at 10:36:09AM +0800, Frank Li wrote:
> > >
> > > All applied to net-next.
> > >
> > > Please make sure your changes are in sync with Ben's PTP/PPS
> > > Kconfig changes of today, and send me any changes if necessary.
> > >
> > 
> > Thank you very much.
> > I checked Ben's patch, which not affect FEC.
> 
> Maybe just remove the Kconfig line "select PPS".

More than that: FEC should select PTP_1588_CLOCK, FEC_PTP should be
removed and all the conditional code made unconditional.  Alternately,
if that would cost too much (in terms of performance or memory) on some
systems where the driver is used, FEC_PTP should default to 'y'.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock
  2012-11-02 23:25       ` Ben Hutchings
@ 2012-11-05 11:23         ` Frank Li
  0 siblings, 0 replies; 6+ messages in thread
From: Frank Li @ 2012-11-05 11:23 UTC (permalink / raw)
  To: Ben Hutchings
  Cc: Frank.Li@freescale.com, netdev@vger.kernel.org, Richard Cochran,
	shawn.guo@linaro.org, David Miller,
	linux-arm-kernel@lists.infradead.org


[-- Attachment #1.1: Type: text/plain, Size: 1239 bytes --]

在 2012年11月3日星期六,Ben Hutchings 写道:

> On Fri, 2012-11-02 at 09:43 +0100, Richard Cochran wrote:
> > On Fri, Nov 02, 2012 at 10:36:09AM +0800, Frank Li wrote:
> > > >
> > > > All applied to net-next.
> > > >
> > > > Please make sure your changes are in sync with Ben's PTP/PPS
> > > > Kconfig changes of today, and send me any changes if necessary.
> > > >
> > >
> > > Thank you very much.
> > > I checked Ben's patch, which not affect FEC.
> >
> > Maybe just remove the Kconfig line "select PPS".
>
> More than that: FEC should select PTP_1588_CLOCK,


okay, I will do that.


> FEC_PTP should be
> removed and all the conditional code made unconditional.  Alternately,
> if that would cost too much (in terms of performance or memory) on some
> systems where the driver is used, FEC_PTP should default to 'y'.


Bd description will be difference between no PTP and PTP hardware,
So driver will not incompatible at two kind of hardware.

I can set it default is Y at MX6 platform.


> Ben.
>
> --
> Ben Hutchings, Staff Engineer, Solarflare
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.
>
>

[-- Attachment #1.2: Type: text/html, Size: 2023 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-11-05 11:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-31  4:24 [PATCH 0/4] Support the MX6 FEC as a PTP hardware clock Frank Li
2012-11-01 16:30 ` David Miller
2012-11-02  2:36   ` Frank Li
2012-11-02  8:43     ` Richard Cochran
2012-11-02 23:25       ` Ben Hutchings
2012-11-05 11:23         ` Frank Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).