From: Richard Cochran <richardcochran@gmail.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: changlongx.xie@intel.com, fengguang.wu@intel.com, netdev@vger.kernel.org
Subject: Re: [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack
Date: Fri, 2 Nov 2012 09:59:15 +0100 [thread overview]
Message-ID: <20121102085915.GC2486@netboy.at.omicron.at> (raw)
In-Reply-To: <20121102020631.GI16883@yliu-dev.sh.intel.com>
On Fri, Nov 02, 2012 at 10:06:31AM +0800, Yuanhan Liu wrote:
>
> Hi Richard,
>
> _just_ FYI and let you aware of it, there are new smatch warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head: b77bc2069d1e437d5a1a71bb5cfcf4556ee40015
> commit: 215b13dd288c2e1e4461c1530a801f5f83e8cd90 [122/152] ptp: add an ioctl to compare PHC time with system time
>
> + drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack
> drivers/ptp/ptp_chardev.c:144 ptp_read() warn: 'event' puts 960 bytes on stack
I am aware that these methods use large stack buffers, but I thought
it was okay seeing as they are both under the 1k limit.
Thanks,
Richard
next prev parent reply other threads:[~2012-11-02 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <509326ff.Rs30l/1GTlOl9dW+%yuanhan.liu@linux.intel.com>
2012-11-02 2:06 ` [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack Yuanhan Liu
2012-11-02 8:59 ` Richard Cochran [this message]
2012-11-03 1:39 ` David Miller
2012-11-03 4:53 ` Richard Cochran
2012-11-03 5:39 ` David Miller
2012-11-26 11:44 ` [PATCH net-next 1/2] ptp: reduce stack usage when reading external time stamps Richard Cochran
2012-11-26 11:44 ` [PATCH net-next 2/2] ptp: reduce stack usage when measuring the system time offset Richard Cochran
2012-11-26 22:23 ` David Miller
2012-11-26 22:23 ` [PATCH net-next 1/2] ptp: reduce stack usage when reading external time stamps David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121102085915.GC2486@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=changlongx.xie@intel.com \
--cc=fengguang.wu@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).