* [PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill
[not found] <1351670761-26749-1-git-send-email-xtfeng@gmail.com>
@ 2012-10-31 8:06 ` Xiaotian Feng
2012-11-03 19:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xiaotian Feng @ 2012-10-31 8:06 UTC (permalink / raw)
To: linux-kernel
Cc: Xiaotian Feng, Xiaotian Feng, Jon Maloy, Allan Stephens,
David S. Miller, netdev, tipc-discussion
If tasklet_disable() is called before related tasklet handled,
tasklet_kill will never be finished. tasklet_kill is enough.
Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Allan Stephens <allan.stephens@windriver.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: tipc-discussion@lists.sourceforge.net
---
net/tipc/handler.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/tipc/handler.c b/net/tipc/handler.c
index 111ff83..b36f0fc 100644
--- a/net/tipc/handler.c
+++ b/net/tipc/handler.c
@@ -116,7 +116,6 @@ void tipc_handler_stop(void)
return;
handler_enabled = 0;
- tasklet_disable(&tipc_tasklet);
tasklet_kill(&tipc_tasklet);
spin_lock_bh(&qitem_lock);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill
2012-10-31 8:06 ` [PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill Xiaotian Feng
@ 2012-11-03 19:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-11-03 19:15 UTC (permalink / raw)
To: xtfeng
Cc: linux-kernel, dannyfeng, jon.maloy, allan.stephens, netdev,
tipc-discussion
From: Xiaotian Feng <xtfeng@gmail.com>
Date: Wed, 31 Oct 2012 16:06:01 +0800
> If tasklet_disable() is called before related tasklet handled,
> tasklet_kill will never be finished. tasklet_kill is enough.
>
> Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-03 19:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1351670761-26749-1-git-send-email-xtfeng@gmail.com>
2012-10-31 8:06 ` [PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill Xiaotian Feng
2012-11-03 19:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).