From: David Miller <davem@davemloft.net>
To: vitas@nppfactor.kiev.ua
Cc: netdev@vger.kernel.org, nicolas.ferre@atmel.com,
plagnioj@jcrosoft.com, havard@skinnemoen.net,
jamie@jamieiles.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] macb: Keep driver's speed/duplex in sync with actual NCFGR
Date: Sat, 03 Nov 2012 15:38:13 -0400 (EDT) [thread overview]
Message-ID: <20121103.153813.1907662993079093598.davem@davemloft.net> (raw)
In-Reply-To: <201211021909.25473.vitas@nppfactor.kiev.ua>
From: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Date: Fri, 2 Nov 2012 19:09:24 +0200
> When underlying phy driver restores its state very fast after being brought
> down and up so that macb driver function macb_handle_link_change() was never
> called with link state "down", driver's internal representation of phy speed
> and duplex (bp->speed and bp->duplex) didn't change. So, macb driver sees no
> reason to perform actual write to the NCFGR register, although the speed and
> duplex settings in that register were reset when interface was brought down
> and up. In that case actual phy speed and duplex differ from NCFGR settings.
> The patch fixes that by keeping internal driver representation of speed and
> duplex in sync with actual content of NCFGR.
>
> Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>
Applied.
prev parent reply other threads:[~2012-11-03 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 17:09 [PATCH net-next] macb: Keep driver's speed/duplex in sync with actual NCFGR Vitalii Demianets
2012-11-03 19:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121103.153813.1907662993079093598.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=havard@skinnemoen.net \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=vitas@nppfactor.kiev.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox