From: David Miller <davem@davemloft.net>
To: pebolle@tiscali.nl
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atp: remove set_rx_mode_8012()
Date: Sat, 03 Nov 2012 15:43:56 -0400 (EDT) [thread overview]
Message-ID: <20121103.154356.693234817224225347.davem@davemloft.net> (raw)
In-Reply-To: <1351936395.1434.2.camel@x61.thuisdomein>
From: Paul Bolle <pebolle@tiscali.nl>
Date: Sat, 03 Nov 2012 10:53:15 +0100
> Building atp.o triggers this GCC warning:
> drivers/net/ethernet/realtek/atp.c: In function ‘set_rx_mode’:
> drivers/net/ethernet/realtek/atp.c:871:26: warning: ‘mc_filter[0]’ may be used uninitialized in this function [-Wuninitialized]
>
> GCC is correct. In promiscuous mode 'mc_filter' will be used
> uninitialized in set_rx_mode_8012(), which is apparently inlined into
> set_rx_mode().
>
> But it turns out set_rx_mode_8012() will never be called, since
> net_local.chip_type will always be RTL8002. So we can just remove
> set_rx_mode_8012() and do some related cleanups.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
prev parent reply other threads:[~2012-11-03 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-03 9:53 [PATCH] atp: remove set_rx_mode_8012() Paul Bolle
2012-11-03 19:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121103.154356.693234817224225347.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox