netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: ethernet: qlogic: qlge_dbg.c: Fixed a coding style issue
@ 2012-11-05  5:11 Kumar Amit Mehta
  2012-11-05 18:45 ` Jitendra Kalsaria
  2012-11-06 23:33 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Kumar Amit Mehta @ 2012-11-05  5:11 UTC (permalink / raw)
  To: jitendra.kalsaria
  Cc: ron.mercer, linux-driver, netdev, linux-kernel, kernel-janitors

checkpatch.pl throws error message for the current code. This patch fixes
this coding style issue.

Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
---
 drivers/net/ethernet/qlogic/qlge/qlge_dbg.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c b/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
index 58185b6..10093f0 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
@@ -86,7 +86,7 @@ exit:
 }
 
 /* Read out the SERDES registers */
-static int ql_read_serdes_reg(struct ql_adapter *qdev, u32 reg, u32 * data)
+static int ql_read_serdes_reg(struct ql_adapter *qdev, u32 reg, u32 *data)
 {
 	int status;
 
@@ -364,7 +364,7 @@ exit:
 /* Read the 400 xgmac control/statistics registers
  * skipping unused locations.
  */
-static int ql_get_xgmac_regs(struct ql_adapter *qdev, u32 * buf,
+static int ql_get_xgmac_regs(struct ql_adapter *qdev, u32 *buf,
 					unsigned int other_function)
 {
 	int status = 0;
@@ -405,7 +405,7 @@ static int ql_get_xgmac_regs(struct ql_adapter *qdev, u32 * buf,
 	return status;
 }
 
-static int ql_get_ets_regs(struct ql_adapter *qdev, u32 * buf)
+static int ql_get_ets_regs(struct ql_adapter *qdev, u32 *buf)
 {
 	int status = 0;
 	int i;
@@ -423,7 +423,7 @@ static int ql_get_ets_regs(struct ql_adapter *qdev, u32 * buf)
 	return status;
 }
 
-static void ql_get_intr_states(struct ql_adapter *qdev, u32 * buf)
+static void ql_get_intr_states(struct ql_adapter *qdev, u32 *buf)
 {
 	int i;
 
@@ -434,7 +434,7 @@ static void ql_get_intr_states(struct ql_adapter *qdev, u32 * buf)
 	}
 }
 
-static int ql_get_cam_entries(struct ql_adapter *qdev, u32 * buf)
+static int ql_get_cam_entries(struct ql_adapter *qdev, u32 *buf)
 {
 	int i, status;
 	u32 value[3];
@@ -471,7 +471,7 @@ err:
 	return status;
 }
 
-static int ql_get_routing_entries(struct ql_adapter *qdev, u32 * buf)
+static int ql_get_routing_entries(struct ql_adapter *qdev, u32 *buf)
 {
 	int status;
 	u32 value, i;
@@ -496,7 +496,7 @@ err:
 }
 
 /* Read the MPI Processor shadow registers */
-static int ql_get_mpi_shadow_regs(struct ql_adapter *qdev, u32 * buf)
+static int ql_get_mpi_shadow_regs(struct ql_adapter *qdev, u32 *buf)
 {
 	u32 i;
 	int status;
@@ -515,7 +515,7 @@ end:
 }
 
 /* Read the MPI Processor core registers */
-static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 * buf,
+static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
 				u32 offset, u32 count)
 {
 	int i, status = 0;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] drivers: ethernet: qlogic: qlge_dbg.c: Fixed a coding style issue
  2012-11-05  5:11 [PATCH] drivers: ethernet: qlogic: qlge_dbg.c: Fixed a coding style issue Kumar Amit Mehta
@ 2012-11-05 18:45 ` Jitendra Kalsaria
  2012-11-06 23:33 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Jitendra Kalsaria @ 2012-11-05 18:45 UTC (permalink / raw)
  To: Kumar Amit Mehta
  Cc: Ron Mercer, Dept-Eng Linux Driver, netdev, linux-kernel,
	kernel-janitors@vger.kernel.org



>From: Kumar Amit Mehta [mailto:gmate.amit@gmail.com] 
>Sent: Sunday, November 04, 2012 9:12 PM
>To: Jitendra Kalsaria
>Cc: Ron Mercer; Dept-Eng Linux Driver; netdev; linux-kernel; kernel-janitors@vger.kernel.org
>Subject: [PATCH] drivers: ethernet: qlogic: qlge_dbg.c: Fixed a coding style issue
>
>checkpatch.pl throws error message for the current code. This patch fixes
>this coding style issue.
>
>Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
>---
> drivers/net/ethernet/qlogic/qlge/qlge_dbg.c |   16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)

Never seen these before with checkpatch.pl when we submitted changes.

Anyway thanks for your effort on fixing it.

Acked-by: Jitendra Kalsaria <Jitendra.kalsaria@qlogic.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers: ethernet: qlogic: qlge_dbg.c: Fixed a coding style issue
  2012-11-05  5:11 [PATCH] drivers: ethernet: qlogic: qlge_dbg.c: Fixed a coding style issue Kumar Amit Mehta
  2012-11-05 18:45 ` Jitendra Kalsaria
@ 2012-11-06 23:33 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-11-06 23:33 UTC (permalink / raw)
  To: gmate.amit
  Cc: jitendra.kalsaria, ron.mercer, linux-driver, netdev, linux-kernel,
	kernel-janitors

From: Kumar Amit Mehta <gmate.amit@gmail.com>
Date: Sun,  4 Nov 2012 21:11:32 -0800

> checkpatch.pl throws error message for the current code. This patch fixes
> this coding style issue.
> 
> Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-11-06 23:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-05  5:11 [PATCH] drivers: ethernet: qlogic: qlge_dbg.c: Fixed a coding style issue Kumar Amit Mehta
2012-11-05 18:45 ` Jitendra Kalsaria
2012-11-06 23:33 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).