From: David Miller <davem@davemloft.net>
To: sony.chacko@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH V6 0/22] qlcnic: patches for new adapter - Qlogic 83XX CNA
Date: Tue, 06 Nov 2012 18:51:24 -0500 (EST) [thread overview]
Message-ID: <20121106.185124.2155177049133289777.davem@davemloft.net> (raw)
In-Reply-To: <1352153535-5006-1-git-send-email-sony.chacko@qlogic.com>
From: Sony Chacko <sony.chacko@qlogic.com>
Date: Mon, 5 Nov 2012 17:11:54 -0500
> I apologize for the above mistake.
> We have fixed the above warning and have verified the rest of the patches.
> Please apply the updated 22 patch series to net-next.
Your changes are still broken:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c: In function ‘qlcnic_fw_create_ctx’:
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c:565:1: warning: the frame size of 8192 bytes is larger than 2048 bytes [-Wframe-larger-than=]
A multi-kilobyte on-stack variable? Are you kidding me?
This submission is terrible, in every way, shape, and form. Nobody
wants to review these changes in detail (have you noticed that besides
me, there is zero feedback coming in from anyone). You have to
recognize that it's demoralizing to review patches when they don't
even build cleanly like your's do.
Stop submitting garbage patches, now.
I want you to not resubmit this for at least a week. You must
eliminate all of these kinds of problems, you must validate the build,
you must double check everything.
And you cannot be trusted to do that in just one or two days.
Again, don't resubmit this until you've worked over and double checked
everything in it for at least a week.
prev parent reply other threads:[~2012-11-06 23:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 22:11 [PATCH V6 0/22] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-11-05 22:11 ` [PATCH V6 01/22] qlcnic: move HW specific data to seperate structure Sony Chacko
2012-11-05 22:11 ` [PATCH V6 02/22] qlcnic: create seperate file for data path routines Sony Chacko
2012-11-05 22:11 ` [PATCH V6 03/22] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-11-05 22:11 ` [PATCH V6 04/22] qlcnic: modify PCI and register access routines Sony Chacko
2012-11-05 22:11 ` [PATCH V6 05/22] qlcnic: change driver hardware interface mechanism Sony Chacko
2012-11-05 22:12 ` [PATCH V6 06/22] qlcnic: macros for common register access Sony Chacko
2012-11-05 22:12 ` [PATCH V6 07/22] qlcnic: update driver resource allocation routines Sony Chacko
2012-11-05 22:12 ` [PATCH V6 08/22] qlcnic: get board name API Sony Chacko
2012-11-05 22:12 ` [PATCH V6 09/22] qlcnic: update NIC partition interface routines Sony Chacko
2012-11-05 22:12 ` [PATCH V6 10/22] qlcnic: cleanup unused register interfaces Sony Chacko
2012-11-05 22:12 ` [PATCH V6 11/22] qlcnic: rename module params with module_param_named Sony Chacko
2012-11-05 22:12 ` [PATCH V6 12/22] qlcnic: 83xx memory map and HW access routines Sony Chacko
2012-11-05 22:12 ` [PATCH V6 13/22] qlcnic: 83xx data path routines Sony Chacko
2012-11-05 22:12 ` [PATCH V6 14/22] qlcnic: 83xx base driver Sony Chacko
2012-11-05 22:12 ` [PATCH V6 15/22] qlcnic: create seperate file for sysfs routines Sony Chacko
2012-11-05 22:12 ` [PATCH V6 16/22] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-11-05 22:12 ` [PATCH V6 18/22] qlcnic: flash template based firmware reset recovery Sony Chacko
2012-11-05 22:12 ` [PATCH V6 19/22] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-11-05 22:12 ` [PATCH V6 20/22] qlcnic: common register dump utility Sony Chacko
2012-11-05 22:12 ` [PATCH V6 22/22] qlcnic: update driver version - 5.1.30 Sony Chacko
2012-11-06 23:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106.185124.2155177049133289777.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).