From: David Miller <davem@davemloft.net>
To: rob.herring@calxeda.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v3 5/6] net: calxedaxgmac: rework transmit ring handling
Date: Tue, 06 Nov 2012 20:10:52 -0500 (EST) [thread overview]
Message-ID: <20121106.201052.1632236238198110122.davem@davemloft.net> (raw)
In-Reply-To: <5099AB57.7000805@calxeda.com>
From: Rob Herring <rob.herring@calxeda.com>
Date: Tue, 06 Nov 2012 18:29:11 -0600
> David,
>
> On 11/06/2012 05:57 PM, David Miller wrote:
>> From: Rob Herring <robherring2@gmail.com>
>> Date: Mon, 5 Nov 2012 10:22:23 -0600
>>
>>> Only generate tx interrupts on every ring size / 4 descriptors.
>>
>> I thought we told you that you cannot do this.
>>
>> With this change if we get a few packets, then stop generating any
>> traffic, there will be SKBs that just sit dead in your TX queue.
>
> And as I previously mentioned, we do get a tx complete interrupt in
> addition. The h/w will interrupt when all packets are transmitted and
> there is not another descriptor ready.
Ok, in that case it's fine. I'll keep reviewing this series then.
next prev parent reply other threads:[~2012-11-07 1:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 16:22 [PATCH v3 0/6] Calxeda xgmac performance fixes Rob Herring
2012-11-05 16:22 ` [PATCH v3 1/6] net: calxedaxgmac: enable operate on 2nd frame mode Rob Herring
2012-11-05 16:22 ` [PATCH v3 2/6] net: calxedaxgmac: remove explicit rx dma buffer polling Rob Herring
2012-11-05 16:22 ` [PATCH v3 3/6] net: calxedaxgmac: use raw i/o accessors in rx and tx paths Rob Herring
2012-11-05 16:22 ` [PATCH v3 4/6] net: calxedaxgmac: drop some unnecessary register writes Rob Herring
2012-11-05 16:22 ` [PATCH v3 5/6] net: calxedaxgmac: rework transmit ring handling Rob Herring
2012-11-06 23:57 ` David Miller
2012-11-07 0:29 ` Rob Herring
2012-11-07 1:10 ` David Miller [this message]
2012-11-05 16:22 ` [PATCH v3 6/6] net: calxedaxgmac: ip align receive buffers Rob Herring
2012-11-05 16:53 ` Eric Dumazet
2012-11-07 8:52 ` [PATCH v3 0/6] Calxeda xgmac performance fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106.201052.1632236238198110122.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).