From: David Miller <davem@davemloft.net>
To: alan@lxorguk.ukuu.org.uk
Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org,
isdn@linux-pingi.de, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES
Date: Wed, 07 Nov 2012 14:42:12 -0500 (EST) [thread overview]
Message-ID: <20121107.144212.1481427869140100342.davem@davemloft.net> (raw)
In-Reply-To: <20121107150436.3d25ee51@pyramind.ukuu.org.uk>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Wed, 7 Nov 2012 15:04:36 +0000
> On Wed, 7 Nov 2012 10:55:03 +0100
> Lee Jones <lee.jones@linaro.org> wrote:
>
>> It doesn't make much sense to enable ISDN services if you don't
>> intend to connect to a network.
>
> I would disagree. However what I don't understand and you've not
> explained is why the current code is a bug or a problem ?
>
> This seems to be a make-work inconvenience causing patch that serves no
> useful purpose ?
The ISDN drivers are peppered with CONFIG_NETDEVICES protection,
but there are missing cases in several locations.
This is ugly, and causes build problems, so adding the dependency
is the cleanest and most correct soluation and I fully intend
to apply this patch.
next prev parent reply other threads:[~2012-11-07 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 9:55 [PATCH 1/1] isdn: Make CONFIG_ISDN depend on CONFIG_NETDEVICES Lee Jones
2012-11-07 15:04 ` Alan Cox
2012-11-07 19:42 ` David Miller [this message]
2012-11-07 23:59 ` David Miller
2012-11-12 17:08 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121107.144212.1481427869140100342.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=isdn@linux-pingi.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).