From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: pull request: batman-adv 2012-11-07 Date: Wed, 07 Nov 2012 19:10:34 -0500 (EST) Message-ID: <20121107.191034.180849843876027251.davem@davemloft.net> References: <1352315502-20324-1-git-send-email-ordex@autistici.org> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org To: ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org Return-path: In-Reply-To: <1352315502-20324-1-git-send-email-ordex-GaUfNO9RBHfsrOwW+9ziJQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Sender: "B.A.T.M.A.N" List-Id: netdev.vger.kernel.org From: Antonio Quartulli Date: Wed, 7 Nov 2012 20:11:30 +0100 > Hello David, > > first of all thank you for having made us aware of the packet format problem in > batman-adv! The impact of __packed on performances was not entirely known to me, > in particular for what concerns the RISC arch. > > We have to change a number of packet formats before we can remove __packed > everywhere which will obviously break compatibility. > > However we already scheduled a compatibility break because we want to > heavily improve our packet formats and to provide a more flexible framework that > would allow us to add new types and features while reducing the probability of > breaking compatibility again and again as happened in the past (we are > implementing TypeLengthValue (TLV) containers among other things). > > To avoid breaking compatibility (at least) twice we decided to fix now (in this > patchset) what is fixable with no consequences to compatibility while we would > ilike to defer the remaining changes for the scheduled compatibility break. > > In this patchset you have the two new features intended for net-next/linux-3.8: > 1) the new UNICAST_4ADDR packet type > 2) the Distributed ARP Table (DAT) component > > The new packet type has been reviewed to entirely address the alignment issue. > At the same time we also reviewed the other packet types but as I told you > before, we will send these changes later. > > Other than that you have patch 02/12 that removes the __packed attribute from > the structures where it was not really needed. Pulled, thanks.