* [PATCH] ipv6: send unsolicited neighbour advertisements to all-nodes
@ 2012-11-07 2:18 Hannes Frederic Sowa
2012-11-09 21:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Frederic Sowa @ 2012-11-07 2:18 UTC (permalink / raw)
To: netdev
As documented in RFC4861 (Neighbor Discovery for IP version 6) 7.2.6.,
unsolicited neighbour advertisements should be sent to the all-nodes
multicast address.
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/ndisc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 61b3354..8271db6 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -535,7 +535,7 @@ static void ndisc_send_unsol_na(struct net_device *dev)
{
struct inet6_dev *idev;
struct inet6_ifaddr *ifa;
- struct in6_addr mcaddr;
+ struct in6_addr mcaddr = IN6ADDR_LINKLOCAL_ALLNODES_INIT;
idev = in6_dev_get(dev);
if (!idev)
@@ -543,7 +543,6 @@ static void ndisc_send_unsol_na(struct net_device *dev)
read_lock_bh(&idev->lock);
list_for_each_entry(ifa, &idev->addr_list, if_list) {
- addrconf_addr_solict_mult(&ifa->addr, &mcaddr);
ndisc_send_na(dev, NULL, &mcaddr, &ifa->addr,
/*router=*/ !!idev->cnf.forwarding,
/*solicited=*/ false, /*override=*/ true,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipv6: send unsolicited neighbour advertisements to all-nodes
2012-11-07 2:18 [PATCH] ipv6: send unsolicited neighbour advertisements to all-nodes Hannes Frederic Sowa
@ 2012-11-09 21:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-11-09 21:22 UTC (permalink / raw)
To: hannes; +Cc: netdev
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Wed, 7 Nov 2012 03:18:41 +0100
> As documented in RFC4861 (Neighbor Discovery for IP version 6) 7.2.6.,
> unsolicited neighbour advertisements should be sent to the all-nodes
> multicast address.
>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-09 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-07 2:18 [PATCH] ipv6: send unsolicited neighbour advertisements to all-nodes Hannes Frederic Sowa
2012-11-09 21:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).