From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] usbnet: ratelimit kevent may have been dropped warnings Date: Fri, 09 Nov 2012 17:00:02 -0500 (EST) Message-ID: <20121109.170002.1224610167622738841.davem@davemloft.net> References: <1352391981-15692-1-git-send-email-steve.glendinning@shawell.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: oneukum@suse.de, netdev@vger.kernel.org To: steve.glendinning@shawell.net Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:38744 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689Ab2KIWAE (ORCPT ); Fri, 9 Nov 2012 17:00:04 -0500 In-Reply-To: <1352391981-15692-1-git-send-email-steve.glendinning@shawell.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Steve Glendinning Date: Thu, 8 Nov 2012 16:26:21 +0000 > when something goes wrong, a flood of these messages can be > generated by usbnet (thousands per second). This doesn't > generally *help* the condition so this patch ratelimits the > rate of their generation. > > There's an underlying problem in usbnet's kevent deferral > mechanism which needs fixing, specifically that events *can* > get dropped and not handled. This patch doesn't address this, > but just mitigates fallout caused by the current implemention. > > Signed-off-by: Steve Glendinning Applied, thanks.