netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: paul.gortmaker@windriver.com
Cc: netdev@vger.kernel.org, dongsheng.wang@freescale.com,
	claudiu.manoil@freescale.com
Subject: Re: [PATCH] gianfar: ethernet vanishes after restoring from hibernation
Date: Fri, 09 Nov 2012 17:08:59 -0500 (EST)	[thread overview]
Message-ID: <20121109.170859.796967518373395470.davem@davemloft.net> (raw)
In-Reply-To: <1352472231-17927-1-git-send-email-paul.gortmaker@windriver.com>

From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Fri,  9 Nov 2012 09:43:51 -0500

> From: Wang Dongsheng <dongsheng.wang@freescale.com>
> 
> If a gianfar ethernet device is down prior to hibernating a
> system, it will no longer be present upon system restore.
> 
> For example:
> 
> 	~# ifconfig eth0 down
> 	~# echo disk > /sys/power/state
> 
> 	  <trigger a restore from hibernation>
> 
> 	~# ifconfig eth0 up
> 	SIOCSIFFLAGS: No such device
> 
> This happens because the restore function bails out early upon
> finding devices that were not up at hibernation.  In doing so,
> it never gets to the netif_device_attach call at the end of
> the restore function.  Adding the netif_device_attach as done
> here also makes the gfar_restore code consistent with what is
> done in the gfar_resume code.
> 
> Cc: Claudiu Manoil <claudiu.manoil@freescale.com>
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Applied, thanks.

      parent reply	other threads:[~2012-11-09 22:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06  6:04 [PATCH] powerpc/gianfar: fix ethernet cannot work after restoring from hibernation Wang Dongsheng
2012-11-09 14:43 ` [PATCH] gianfar: ethernet vanishes " Paul Gortmaker
2012-11-09 16:02   ` Claudiu Manoil
2012-11-09 22:08   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121109.170859.796967518373395470.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=claudiu.manoil@freescale.com \
    --cc=dongsheng.wang@freescale.com \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).