* [PATCH] ipv6: setsockopt(IPIPPROTO_IPV6,IPV6_MINHOPCOUNT) forgot to set return value
@ 2012-11-11 5:52 Hannes Frederic Sowa
2012-11-12 0:20 ` Stephen Hemminger
2012-11-13 19:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Frederic Sowa @ 2012-11-11 5:52 UTC (permalink / raw)
To: netdev; +Cc: shemminger
Cc: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/ipv6_sockglue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
index ba6d13d..e02faed 100644
--- a/net/ipv6/ipv6_sockglue.c
+++ b/net/ipv6/ipv6_sockglue.c
@@ -827,6 +827,7 @@ pref_skip_coa:
if (val < 0 || val > 255)
goto e_inval;
np->min_hopcount = val;
+ retv = 0;
break;
case IPV6_DONTFRAG:
np->dontfrag = valbool;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6: setsockopt(IPIPPROTO_IPV6,IPV6_MINHOPCOUNT) forgot to set return value
2012-11-11 5:52 [PATCH] ipv6: setsockopt(IPIPPROTO_IPV6,IPV6_MINHOPCOUNT) forgot to set return value Hannes Frederic Sowa
@ 2012-11-12 0:20 ` Stephen Hemminger
2012-11-13 19:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2012-11-12 0:20 UTC (permalink / raw)
To: Hannes Frederic Sowa; +Cc: netdev
Wonder if this ever worked? The patch should go
to stable as well.
The original coding style was prone to these kind of errors
because of the use of "goto e_inval" to do the unlock, and fall through
is prone to these kind of errors.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipv6: setsockopt(IPIPPROTO_IPV6,IPV6_MINHOPCOUNT) forgot to set return value
2012-11-11 5:52 [PATCH] ipv6: setsockopt(IPIPPROTO_IPV6,IPV6_MINHOPCOUNT) forgot to set return value Hannes Frederic Sowa
2012-11-12 0:20 ` Stephen Hemminger
@ 2012-11-13 19:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-11-13 19:39 UTC (permalink / raw)
To: hannes; +Cc: netdev, shemminger
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sun, 11 Nov 2012 06:52:34 +0100
> Cc: Stephen Hemminger <shemminger@vyatta.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-13 19:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-11 5:52 [PATCH] ipv6: setsockopt(IPIPPROTO_IPV6,IPV6_MINHOPCOUNT) forgot to set return value Hannes Frederic Sowa
2012-11-12 0:20 ` Stephen Hemminger
2012-11-13 19:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).