From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [RFC net-next] tun: implement BQL
Date: Mon, 12 Nov 2012 13:22:41 -0800 [thread overview]
Message-ID: <20121112132241.12bb94e4@nehalam.linuxnetplumber.net> (raw)
Add multiqueue BQL to tap device. Tested with VPN, doesn't have a big impact,
most likely because there is little queueing occuring at TAP device except
under case of forwarding.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/tun.c 2012-11-12 07:58:45.527037947 -0800
+++ b/drivers/net/tun.c 2012-11-12 11:20:26.017512742 -0800
@@ -412,6 +412,7 @@ static void __tun_detach(struct tun_file
tun_flow_delete_by_queue(tun, tun->numqueues + 1);
/* Drop read queue */
skb_queue_purge(&tfile->sk.sk_receive_queue);
+ netdev_tx_reset_queue(netdev_get_tx_queue(dev, index));
tun_set_real_num_queues(tun);
if (tun->numqueues == 0 && !(tun->flags & TUN_PERSIST))
@@ -455,6 +456,7 @@ static void tun_detach_all(struct net_de
lockdep_rtnl_is_held());
/* Drop read queue */
skb_queue_purge(&tfile->sk.sk_receive_queue);
+ netdev_tx_reset_queue(netdev_get_tx_queue(dev, i));
sock_put(&tfile->sk);
}
}
@@ -712,6 +714,8 @@ static netdev_tx_t tun_net_xmit(struct s
* for indefinite time. */
if (unlikely(skb_orphan_frags(skb, GFP_ATOMIC)))
goto drop;
+
+ netdev_tx_sent_queue(netdev_get_tx_queue(dev, txq), skb->len);
skb_orphan(skb);
/* Enqueue packet */
@@ -1324,6 +1328,10 @@ static ssize_t tun_do_read(struct tun_st
netif_wake_subqueue(tun->dev, tfile->queue_index);
ret = tun_put_user(tun, tfile, skb, iv, len);
+
+ netdev_tx_completed_queue(netdev_get_tx_queue(tun->dev,
+ tfile->queue_index),
+ 1, skb->len);
kfree_skb(skb);
break;
}
next reply other threads:[~2012-11-12 21:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 21:22 Stephen Hemminger [this message]
2012-11-13 22:19 ` [RFC net-next] tun: implement BQL David Miller
2012-11-13 22:39 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121112132241.12bb94e4@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).