From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: gregory.v.rose@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 04/11] ixgbevf: Add flag to indicate when rx is in net poll
Date: Tue, 13 Nov 2012 14:20:05 -0500 (EST) [thread overview]
Message-ID: <20121113.142005.106273728495001348.davem@davemloft.net> (raw)
In-Reply-To: <1352815405-751-5-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 13 Nov 2012 06:03:18 -0800
> From: Greg Rose <gregory.v.rose@intel.com>
>
> napi_gro_receive shouldn't be called from netpoll context. Doing
> so was causing kernel panics when jumbo frames larger than 2K were set.
> Add a flag to check if the Rx ring processing is occurring from interrupt
> context or from netpoll context and call netif_rx() if in the polling
> context.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Tested-by: Sibai Li <sibai.li@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This is not a scalable solution.
It is not prudent to have every single driver do a check like
this. If using GRO receive from netpoll causes problems,
then it's a generic issue rather than a driver specific one.
next prev parent reply other threads:[~2012-11-13 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 14:03 [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-11-13 14:03 ` [net-next 01/11] ixgbe: Do not use DCA to prefetch the entire packet into the cache Jeff Kirsher
2012-11-13 14:13 ` Eric Dumazet
2012-11-13 17:41 ` Alexander Duyck
2012-11-13 14:03 ` [net-next 02/11] ixgbevf: make sure probe fails on MSI-X enable error Jeff Kirsher
2012-11-13 14:03 ` [net-next 03/11] ixgbevf: fix possible use of uninitialized variable Jeff Kirsher
2012-11-13 14:03 ` [net-next 04/11] ixgbevf: Add flag to indicate when rx is in net poll Jeff Kirsher
2012-11-13 19:20 ` David Miller [this message]
2012-11-13 19:25 ` Greg Rose
2012-11-13 14:03 ` [net-next 05/11] ixgbevf: Reduce size of maximum rx buffer Jeff Kirsher
2012-11-13 14:03 ` [net-next 06/11] igb: Clear Go Link Disconnect for 82580 and later devices Jeff Kirsher
2012-11-13 14:03 ` [net-next 07/11] igb: Support for modifying UDP RSS flow hashing Jeff Kirsher
2012-11-13 14:03 ` [net-next 08/11] igb: Make TSO check for CHECKSUM_PARTIAL to avoid skb_is_gso check Jeff Kirsher
2012-11-13 14:03 ` [net-next 09/11] igb: Update igb Tx flags to improve code efficiency Jeff Kirsher
2012-11-13 14:03 ` [net-next 10/11] igb: Improve performance and reduce size of igb_tx_map Jeff Kirsher
2012-11-13 14:03 ` [net-next 11/11] igb: Ethtool support to enable and disable EEE Jeff Kirsher
2012-11-13 19:19 ` [net-next 00/11][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113.142005.106273728495001348.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).