From: David Miller <davem@davemloft.net>
To: ariele@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH 01/22] bnx2x: Support probing and removing of VF device
Date: Tue, 13 Nov 2012 14:22:13 -0500 (EST) [thread overview]
Message-ID: <20121113.142213.2194625760657823261.davem@davemloft.net> (raw)
In-Reply-To: <1352823451-27042-2-git-send-email-ariele@broadcom.com>
From: "Ariel Elior" <ariele@broadcom.com>
Date: Tue, 13 Nov 2012 18:17:10 +0200
> @@ -1579,6 +1598,7 @@ struct bnx2x {
> char fw_ver[32];
> const struct firmware *firmware;
>
> +
> /* DCB support on/off */
> u16 dcb_state;
> #define BNX2X_DCB_STATE_OFF 0
Please re-review this entire patch series and get rid of
gratuitous things like the unnecessary empty line being
added here.
Thanks.
next prev parent reply other threads:[~2012-11-13 19:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 16:17 [PATCH 00/20] bnx2x: support SR-IOV Ariel Elior
2012-11-13 16:17 ` [PATCH 01/22] bnx2x: Support probing and removing of VF device Ariel Elior
2012-11-13 19:22 ` David Miller [this message]
2012-11-13 16:17 ` [PATCH 02/22] bnx2x: VF <-> PF channel 'acquire' at vf probe Ariel Elior
2012-11-13 16:17 ` [PATCH 03/22] bnx2x: Add to VF <-> PF channel the release request Ariel Elior
2012-11-13 16:17 ` [PATCH 04/22] bnx2x: Separate VF and PF logic Ariel Elior
2012-11-13 16:17 ` [PATCH 05/22] bnx2x: Add init, setup_q, set_mac to VF <-> PF channel Ariel Elior
2012-11-13 16:17 ` [PATCH 06/22] bnx2x: Add teardown_q and close " Ariel Elior
2012-11-13 16:17 ` [PATCH 07/22] bnx2x: Support ndo_set_rxmode in VF driver Ariel Elior
2012-11-13 16:17 ` [PATCH 08/22] bnx2x: VF fastpath Ariel Elior
2012-11-13 16:17 ` [PATCH 09/22] bnx2x: Allocate VF database in PF when VFs are present Ariel Elior
2012-11-13 16:17 ` [PATCH 10/22] bnx2x: Prepare device and initialize VF database Ariel Elior
2012-11-13 16:17 ` [PATCH 11/22] bnx2x: Infrastructure for VF <-> PF request on PF side Ariel Elior
2012-11-13 16:17 ` [PATCH 12/22] bnx2x: Support of PF driver of a VF acquire request Ariel Elior
2012-11-13 16:17 ` [PATCH 13/22] bnx2x: Support of PF driver of a VF init request Ariel Elior
2012-11-13 16:17 ` [PATCH 14/22] bnx2x: Support statistics collection for VFs by the PF Ariel Elior
2012-11-13 16:17 ` [PATCH 15/22] bnx2x: Support of PF driver of a VF setup_q request Ariel Elior
2012-11-13 16:17 ` [PATCH 16/22] bnx2x: Support of PF driver of a VF q_filters request Ariel Elior
2012-11-13 16:17 ` [PATCH 17/22] bnx2x: Support of PF driver of a VF q_teardown request Ariel Elior
2012-11-13 16:17 ` [PATCH 18/22] bnx2x: Support of PF driver of a VF close request Ariel Elior
2012-11-13 16:17 ` [PATCH 19/22] bnx2x: Support of PF driver of a VF release request Ariel Elior
2012-11-13 16:17 ` [PATCH 20/22] bnx2x: Support VF FLR Ariel Elior
2012-11-13 16:17 ` [PATCH 21/22] bnx2x: Support PF <-> VF Bulletin Board Ariel Elior
2012-11-13 16:17 ` [PATCH 22/22] bnx2x: Add VF device ids and enable feature Ariel Elior
2012-11-13 16:20 ` [PATCH 00/20] bnx2x: support SR-IOV Ariel Elior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113.142213.2194625760657823261.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox