From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@intel.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH] vxlan: Fix error that was resulting in VXLAN MTU size being 10 bytes too large
Date: Tue, 13 Nov 2012 14:37:19 -0500 (EST) [thread overview]
Message-ID: <20121113.143719.1473223615602040380.davem@davemloft.net> (raw)
In-Reply-To: <20121109233354.17208.36271.stgit@gitlad.jf.intel.com>
From: Alexander Duyck <alexander.h.duyck@intel.com>
Date: Fri, 09 Nov 2012 15:35:24 -0800
> This change fixes an issue I found where VXLAN frames were fragmented when
> they were up to the VXLAN MTU size. I root caused the issue to the fact that
> the headroom was 4 + 20 + 8 + 8. This math doesn't appear to be correct
> because we are not inserting a VLAN header, but instead a 2nd Ethernet header.
> As such the math for the overhead should be 20 + 8 + 8 + 14 to account for the
> extra headers that are inserted for VXLAN.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Applied, thanks for the detailed commit message.
next prev parent reply other threads:[~2012-11-13 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 23:35 [PATCH] vxlan: Fix error that was resulting in VXLAN MTU size being 10 bytes too large Alexander Duyck
2012-11-13 19:37 ` David Miller [this message]
2012-11-13 21:33 ` Stephen Hemminger
2012-11-13 23:10 ` [PATCH] vxlan: Update hard_header_len based on lowerdev when instantiating VXLAN Alexander Duyck
2012-11-13 23:12 ` Stephen Hemminger
2012-11-13 23:20 ` David Miller
2012-11-19 11:33 ` [PATCH] vxlan: Fix error that was resulting in VXLAN MTU size being 10 bytes too large Joseph Glanville
2012-11-19 16:03 ` Stephen Hemminger
2012-11-19 23:37 ` Joseph Glanville
2012-12-03 15:26 ` Joseph Glanville
2012-12-04 0:48 ` Re[2]: " Naoto MATSUMOTO
2012-12-04 17:12 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113.143719.1473223615602040380.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).