From: Stephen Hemminger <shemminger@vyatta.com>
To: Joachim Eastwood <manabian@gmail.com>
Cc: davem@davemloft.net, pcnet32@frontier.com,
nicolas.ferre@atmel.com, mlindner@marvell.com, nico@fluxnic.net,
steve.glendinning@shawell.net,
uclinux-dist-devel@blackfin.uclinux.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH] net/ethernet: remove useless is_valid_ether_addr from drivers ndo_open
Date: Tue, 13 Nov 2012 13:55:19 -0800 [thread overview]
Message-ID: <20121113135519.1e02be53@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1352843199-24869-1-git-send-email-manabian@gmail.com>
On Tue, 13 Nov 2012 22:46:39 +0100
Joachim Eastwood <manabian@gmail.com> wrote:
> diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
> index d19a143..ce8d053 100644
> --- a/drivers/net/ethernet/marvell/skge.c
> +++ b/drivers/net/ethernet/marvell/skge.c
> @@ -2524,9 +2524,6 @@ static int skge_up(struct net_device *dev)
> size_t rx_size, tx_size;
> int err;
>
> - if (!is_valid_ether_addr(dev->dev_addr))
> - return -EINVAL;
> -
> netif_info(skge, ifup, skge->netdev, "enabling interface\n");
>
> if (dev->mtu > RX_BUF_SIZE)
This should probably stay since it costs so little and protects
against a obscure error case.
skge_up is called from skge_resume on resume from suspend.
It is possible that the device was zeroed after skge_suspend was
called.
next prev parent reply other threads:[~2012-11-13 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 21:46 [net-next PATCH] net/ethernet: remove useless is_valid_ether_addr from drivers ndo_open Joachim Eastwood
2012-11-13 21:55 ` Stephen Hemminger [this message]
2012-11-13 22:07 ` Joachim Eastwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121113135519.1e02be53@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=manabian@gmail.com \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=nicolas.ferre@atmel.com \
--cc=pcnet32@frontier.com \
--cc=steve.glendinning@shawell.net \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).