From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH v6 2/7] net: mvneta: driver for Marvell Armada 370/XP
 network unit
Date: Tue, 13 Nov 2012 16:46:58 +0100
Message-ID: <20121113164658.03ae12f8@skate>
References: <1352818843-4457-1-git-send-email-thomas.petazzoni@free-electrons.com>
	<1352818843-4457-3-git-send-email-thomas.petazzoni@free-electrons.com>
	<1352820622.24230.31.camel@joe-AO722>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "David S. Miller" <davem@davemloft.net>,
	Francois Romieu <romieu@fr.zoreil.com>,
	Lennert Buytenhek <kernel@wantstofly.org>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jason Cooper <jason@lakedaemon.net>,
	Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>,
	Dmitri Epshtein <dima@marvell.com>
To: Joe Perches <joe@perches.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.free-electrons.com ([88.190.12.23]:50362 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754046Ab2KMPrO (ORCPT
	<rfc822;netdev@vger.kernel.org>); Tue, 13 Nov 2012 10:47:14 -0500
In-Reply-To: <1352820622.24230.31.camel@joe-AO722>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Joe,

On Tue, 13 Nov 2012 07:30:22 -0800, Joe Perches wrote:
> On Tue, 2012-11-13 at 16:00 +0100, Thomas Petazzoni wrote:
> > This patch contains a new network driver for the network unit of the
> > ARM Marvell Armada 370 and the Armada XP. Both SoCs use the PJ4B
> > processor, a Marvell-developed ARM core that implements the ARMv7
> > instruction set.
> 
> This looks very clean to me.

Thanks!

With the below fixes, may I get your formal Acked-by on the driver
patch?

> trivial:
> some of the logging doesn't use terminating newlines.
> 
> > +static int mvneta_check_mtu_valid(struct net_device *dev, int mtu)
> > +{
> []
> > +       if (mtu > 9676) {
> > +               netdev_info(dev, "Illegal MTU value %d, round to 9676", mtu);
> []
> > +	if (!IS_ALIGNED(MVNETA_RX_PKT_SIZE(mtu), 8)) {
> > +		netdev_info(dev, "Illegal MTU value %d, rounding to %d",
> 
> missing newlines
> 
> > +static int __devinit mvneta_probe(struct platform_device *pdev)
> []
> > +	if (register_netdev(dev)) {
> > +		dev_err(&pdev->dev, "failed to register\n");
> > +		err = ENOMEM;
> > +		goto err_base;
> > +	}
> []
> > +	dev_info(&pdev->dev, "%s, mac: %pM\n", dev->name,
> > +		 dev->dev_addr);
> 
> You could use netdev_info here
> 
> 	netdev_info(dev, "mac: %pM\n", dev->dev_addr);

Thanks for those comments, I'll wait a bit to see if any other comment
shows up before tomorrow, and I'll send a v7 with those issues fixed.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com