From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 2/3] sit: fix sparse warnings Date: Thu, 15 Nov 2012 13:56:57 -0500 (EST) Message-ID: <20121115.135657.2062640751298716811.davem@davemloft.net> References: <1352985602.4497.31.camel@edumazet-glaptop> <1352988402-16950-1-git-send-email-nicolas.dichtel@6wind.com> <1352988402-16950-2-git-send-email-nicolas.dichtel@6wind.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, fengguang.wu@intel.com To: nicolas.dichtel@6wind.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:46920 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1768722Ab2KOS46 (ORCPT ); Thu, 15 Nov 2012 13:56:58 -0500 In-Reply-To: <1352988402-16950-2-git-send-email-nicolas.dichtel@6wind.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nicolas Dichtel Date: Thu, 15 Nov 2012 15:06:41 +0100 > This change fixes several sparse warnings about endianness problem. The wrong > nla_*() functions were used. > It also fix a sparse warning about a flag test (field i_flags). This field is > used in this file like a local flag only, so it is more an u16 (gre uses it as a > be16). This sparse warning was already there before the patch that add netlink > management, the code has just been moved. > > Reported-by: Fengguang Wu > Signed-off-by: Nicolas Dichtel Applied.