From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, jln@google.com
Subject: Re: [PATCH] tcp: handle tcp_net_metrics_init() order-5 memory allocation failures
Date: Fri, 16 Nov 2012 13:37:11 -0500 (EST) [thread overview]
Message-ID: <20121116.133711.1809052219019793698.davem@davemloft.net> (raw)
In-Reply-To: <1353079913.10798.31.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 16 Nov 2012 07:31:53 -0800
> Well, we dont really know what the size needs to be, and your proposal
> reduces the size by a 4 factor, even for the initial namespace.
>
> Julien report was about Chrome browser own netns, on a suspend/resume
> cycle (or something like that)
>
> If size can influence behavior, we could try a vmalloc() if kmalloc()
> fails...
Agreed.
> [PATCH v3] tcp: handle tcp_net_metrics_init() order-5 memory allocation failures
>
> order-5 allocations can fail with current kernels, we should
> try vmalloc() as well.
>
> Reported-by: Julien Tinnes <jln@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
This looks great, applied, thanks.
next prev parent reply other threads:[~2012-11-16 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 23:41 [PATCH] tcp: handle tcp_net_metrics_init() order-5 memory allocation failures Eric Dumazet
2012-11-15 23:55 ` Joe Perches
2012-11-16 0:47 ` Eric Dumazet
2012-11-16 6:39 ` David Miller
2012-11-16 15:31 ` Eric Dumazet
2012-11-16 18:37 ` David Miller [this message]
2012-11-16 18:51 ` Julien Tinnes
2012-11-16 19:08 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121116.133711.1809052219019793698.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jln@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox