netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: David Miller <davem@davemloft.net>
Cc: patrick.trantham@fuel7.com, netdev@vger.kernel.org,
	steve.glendinning@shawell.net, otavio@ossystems.com.br,
	chohnstaedt@innominate.com, jkosina@suse.cz
Subject: Re: [PATCH] net: phy: smsc: Re-enable EDPD mode for LAN87xx
Date: Fri, 16 Nov 2012 01:04:33 +0100	[thread overview]
Message-ID: <201211160104.33846.marex@denx.de> (raw)
In-Reply-To: <20121115.174910.1186195664618812261.davem@davemloft.net>

Dear David Miller,

> From: Patrick Trantham <patrick.trantham@fuel7.com>
> Date: Thu, 15 Nov 2012 13:00:57 -0600
> 
> > This patch re-enables Energy Detect Power Down (EDPD) mode for the
> > LAN8710/LAN8720.  EDPD mode was disabled in a previous commit,
> > (b629820d18fa65cc598390e4b9712fd5f83ee693), because it was causing the
> > PHY to not be able to detect a link when cold started without a cable
> > connected.
> > 
> > The LAN8710/LAN8720 requires a minimum of 2 link pulses within 64ms of
> > each other in order to set the ENERGYON bit and exit EDPD mode.  If a
> > link partner does send the pulses within this interval, the PHY will
> > remained powered down.
> > 
> > This workaround will manually toggle the PHY on/off upon calls to
> > read_status in order to generate link test pulses if the link is down.
> > If a link partner is present, it will respond to the pulses, which will
> > cause the ENERGYON bit to be set and will cause the EDPD mode to be
> > exited.
> > 
> > Signed-off-by: Patrick Trantham <patrick.trantham@fuel7.com>
> 
> Applied to net-next, thanks.

Can you please wait a bit until it gets a few tests ?

Best regards,
Marek Vasut

  reply	other threads:[~2012-11-16  0:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 19:00 [PATCH] net: phy: smsc: Re-enable EDPD mode for LAN87xx Patrick Trantham
2012-11-15 22:49 ` David Miller
2012-11-16  0:04   ` Marek Vasut [this message]
2012-11-16  1:34     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201211160104.33846.marex@denx.de \
    --to=marex@denx.de \
    --cc=chohnstaedt@innominate.com \
    --cc=davem@davemloft.net \
    --cc=jkosina@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=otavio@ossystems.com.br \
    --cc=patrick.trantham@fuel7.com \
    --cc=steve.glendinning@shawell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).