netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: ordex@autistici.org, netdev@vger.kernel.org,
	b.a.t.m.a.n@lists.open-mesh.org, lindner_marek@yahoo.de
Subject: Re: [PATCH 04/10] batman-adv: export compatibility version via debugfs
Date: Mon, 19 Nov 2012 14:10:41 -0500 (EST)	[thread overview]
Message-ID: <20121119.141041.1333512822842997190.davem@davemloft.net> (raw)
In-Reply-To: <1353351150.4156.4.camel@bwh-desktop.uk.solarflarecom.com>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 19 Nov 2012 18:52:30 +0000

> On Mon, 2012-11-19 at 09:24 +0100, Antonio Quartulli wrote:
>> Different versions of the batman-adv module may use the same compatibility
>> version, but this is not understandable at runtime (the only way is to parse the
>> kernel log and fetch the batman-adv advertisement message on loading). The user
>> may want to know whether two nodes using different versions can communicate or
>> not. For this purpose the module has to export this value through debugfs.
> [...]
> 
> I do hope that you're not planning to use unstable debugfs interfaces
> indefinitely.

I think this is a huge mess and I don't think I'm going to pull this
series for that reason.

Once we allow you to merge your protocol/facility/whatever into the
main kernel tree, you have to be mindful of compatability in a very
real way.

These kinds of changes show that this isn't actually happening.

So the only weapon I have against you doing more foolishly
incompatable changes is to simply stop taking your submissions until
things are corrected.

  reply	other threads:[~2012-11-19 19:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19  8:24 pull request: batman-adv 2012-11-19 Antonio Quartulli
2012-11-19  8:24 ` [PATCH 01/10] batman-adv: Mark best gateway in transtable_global debugfs Antonio Quartulli
2012-11-19  8:24 ` [PATCH 02/10] batman-adv: fix bla compare function Antonio Quartulli
2012-11-19  8:24 ` [PATCH 03/10] batman-adv: support array of debugfs general attributes Antonio Quartulli
2012-11-19  8:24 ` [PATCH 04/10] batman-adv: export compatibility version via debugfs Antonio Quartulli
2012-11-19 18:52   ` Ben Hutchings
2012-11-19 19:10     ` David Miller [this message]
2012-11-19 19:29     ` [B.A.T.M.A.N.] " Sven Eckelmann
2012-11-19 19:40       ` Ben Hutchings
2012-11-19 20:25         ` Re: [B.A.T.M.A.N.] " Sven Eckelmann
2012-11-19 19:47       ` David Miller
     [not found]         ` <20121119.144745.1093556126398582629.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-11-19 21:09           ` Antonio Quartulli
2012-11-19  8:24 ` [PATCH 05/10] batman-adv: Add wrapper to look up neighbor and send skb Antonio Quartulli
2012-11-19  8:24 ` [PATCH 06/10] batman-adv: sysfs documentation should keep alphabetical order Antonio Quartulli
2012-11-19  8:24 ` [PATCH 07/10] batman-adv: Add function to calculate crc32c for the skb payload Antonio Quartulli
2012-11-19  8:24 ` [PATCH 08/10] batman-adv: Fix broadcast duplist for fragmentation Antonio Quartulli
2012-11-19  8:24 ` [PATCH 09/10] batman-adv: Start new development cycle Antonio Quartulli
2012-11-19  8:24 ` [PATCH 10/10] batman-adv: Use packing of 2 for all headers before an ethernet header Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119.141041.1333512822842997190.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=bhutchings@solarflare.com \
    --cc=lindner_marek@yahoo.de \
    --cc=netdev@vger.kernel.org \
    --cc=ordex@autistici.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).