From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com, gallatin@myri.com,
herbert@gondor.apana.org.au
Subject: Re: [PATCH net-next] gro: Handle inline VLAN tags
Date: Mon, 19 Nov 2012 19:10:02 -0500 (EST) [thread overview]
Message-ID: <20121119.191002.1995098917961576324.davem@davemloft.net> (raw)
In-Reply-To: <1353114559.10798.66.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 16 Nov 2012 17:09:19 -0800
> On Sat, 2012-11-17 at 00:32 +0000, Ben Hutchings wrote:
>> On Fri, 2012-11-16 at 16:16 -0800, Eric Dumazet wrote:
>> > On Sat, 2012-11-17 at 00:00 +0000, Ben Hutchings wrote:
>> >
>> > > I'm not sure what you mean by this. Is your point that the
>> > > copy-on-write is never needed? It is still possible for pskb_may_pull()
>> > > to fail.
>> > >
>> >
>> > A packet sniffer should have a copy of bad frames, even if dropped later
>> > in our stacks.
>> >
>> > GRO layer is not allowed to drop a frame, even if not 'correct'.
>>
>> What do you think the accelerated hardware does with frames that have a
>> truncated VLAN tag?
>
> The hardware should send us the frame, exactly like when RX checksum is
> wrong.
I agree with Eric, and therefore will not apply this patch.
next prev parent reply other threads:[~2012-11-20 0:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 20:17 [PATCH net-next] gro: Handle inline VLAN tags Ben Hutchings
2012-11-16 23:01 ` Eric Dumazet
2012-11-17 0:00 ` Ben Hutchings
2012-11-17 0:16 ` Eric Dumazet
2012-11-17 0:32 ` Ben Hutchings
2012-11-17 1:09 ` Eric Dumazet
2012-11-20 0:10 ` David Miller [this message]
2012-11-26 15:04 ` Andrew Gallatin
2012-11-28 16:46 ` David Miller
2012-11-28 17:30 ` Andrew Gallatin
2012-11-28 18:39 ` David Miller
2012-11-17 1:17 ` Andrew Gallatin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119.191002.1995098917961576324.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=gallatin@myri.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).