From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: paolo.valente@unimore.it, jhs@mojatatu.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rizzo@iet.unipi.it, fchecconi@gmail.com
Subject: Re: [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost
Date: Tue, 20 Nov 2012 13:02:02 -0500 (EST) [thread overview]
Message-ID: <20121120.130202.1918742054229219388.davem@davemloft.net> (raw)
In-Reply-To: <20121120095304.420ded7c@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 20 Nov 2012 09:53:04 -0800
> There are actually lots of bogus warnings than seem to only occur
> because gcc 4.4 does a bad job of checking. Later versions are fixed
> and don't generate warnings.
>
> My preference is to not add the unnecessary initialization because
> if you get in the habit of doing it. The whole purpose of the uninitialized
> check is lost.
Try again, this was with gcc-4.7.2-2 on Fedora.
There are too many preconditions, across multiple basic block, which
together ensure the skb is in fact initialized at the point in
question and the compiler simply isn't sophisticated enough to see
that.
next prev parent reply other threads:[~2012-11-20 18:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 16:48 [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost Paolo Valente
2012-11-19 23:48 ` David Miller
2012-11-20 17:45 ` Paolo Valente
2012-11-20 17:53 ` Stephen Hemminger
2012-11-20 18:02 ` David Miller [this message]
2012-11-20 18:09 ` Stephen Hemminger
2012-11-20 18:15 ` David Miller
2012-11-20 18:44 ` Stephen Hemminger
2012-11-20 18:00 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-11-20 17:45 Paolo Valente
2012-11-20 18:54 ` David Miller
2012-11-21 9:45 ` Paolo Valente
2012-11-21 17:04 ` David Miller
2012-11-22 16:56 Paolo Valente
2012-11-23 19:28 ` David Miller
2012-11-23 21:02 ` Paolo Valente
2012-11-23 21:03 Paolo Valente
2012-11-28 16:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120.130202.1918742054229219388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fchecconi@gmail.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=rizzo@iet.unipi.it \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).