From: Dan Carpenter <dan.carpenter@oracle.com>
To: jpirko@redhat.com
Cc: netdev@vger.kernel.org
Subject: re: team: add broadcast mode
Date: Tue, 20 Nov 2012 22:23:07 +0300 [thread overview]
Message-ID: <20121120192307.GA10278@elgon.mountain> (raw)
Hello Jiri Pirko,
The patch 5fc889911a99: "team: add broadcast mode" from Jul 11, 2012,
leads to the following Smatch warning:
drivers/net/team/team_mode_broadcast.c:46 bc_transmit()
warn: signedness bug returning '18446744073709551516'
The error message sucks because 18446744073709551516 is -100 as an int,
and I'm not sure how it figures this returns -100...
But actually there is a signedness bug in bc_transmit(). We return
error codes from team_dev_queue_xmit() and cast them to 1 as bool. This
function is supposed to return 1 on success but instead it returns zero.
regards,
dan carpenter
next reply other threads:[~2012-11-20 19:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 19:23 Dan Carpenter [this message]
2012-11-21 9:36 ` team: add broadcast mode Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120192307.GA10278@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox