From: David Miller <davem@davemloft.net>
To: steve.glendinning@shawell.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] smsc95xx: support PHY wakeup source
Date: Wed, 21 Nov 2012 12:07:21 -0500 (EST) [thread overview]
Message-ID: <20121121.120721.1391625922017753607.davem@davemloft.net> (raw)
In-Reply-To: <1353504577-5719-2-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Wed, 21 Nov 2012 13:29:37 +0000
> +{
> + struct mii_if_info *mii = &dev->mii;
> +
> + /* first, a dummy read, needed to latch some MII phys */
> + int ret = smsc95xx_mdio_read_nopm(dev->net, mii->phy_id, MII_BMSR);
Please keep the local variable declarations together at the beginning
of the basic block, don't intermix empty lines and comments as you
are doing here.
next prev parent reply other threads:[~2012-11-21 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:29 [PATCH 1/2] smsc95xx: detect chip revision specific features Steve Glendinning
2012-11-21 13:29 ` [PATCH 2/2] smsc95xx: support PHY wakeup source Steve Glendinning
2012-11-21 17:07 ` David Miller [this message]
2012-11-22 12:03 ` Steve Glendinning
2012-11-21 17:06 ` [PATCH 1/2] smsc95xx: detect chip revision specific features David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121.120721.1391625922017753607.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).