* [PATCH] net: sched: enable CAN Identifier to be build into kernel
@ 2012-11-23 10:44 Marc Kleine-Budde
2012-11-23 19:22 ` David Miller
2012-11-25 21:06 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Marc Kleine-Budde @ 2012-11-23 10:44 UTC (permalink / raw)
To: netdev; +Cc: linux-can, Marc Kleine-Budde
This patch makes it possible to build the CAN Identifier into the kernel, even
if the CAN support is build as a module.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Hello,
is there a nicer solution to this problem? Or remove the "&& CAN" at all?
Marc
net/sched/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index 62fb51f..235e01a 100644
--- a/net/sched/Kconfig
+++ b/net/sched/Kconfig
@@ -509,7 +509,7 @@ config NET_EMATCH_TEXT
config NET_EMATCH_CANID
tristate "CAN Identifier"
- depends on NET_EMATCH && CAN
+ depends on NET_EMATCH && (CAN=y || CAN=m)
---help---
Say Y here if you want to be able to classify CAN frames based
on CAN Identifier.
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: sched: enable CAN Identifier to be build into kernel
2012-11-23 10:44 [PATCH] net: sched: enable CAN Identifier to be build into kernel Marc Kleine-Budde
@ 2012-11-23 19:22 ` David Miller
2012-11-24 12:22 ` Marc Kleine-Budde
2012-11-25 21:06 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2012-11-23 19:22 UTC (permalink / raw)
To: mkl; +Cc: netdev, linux-can
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Fri, 23 Nov 2012 11:44:57 +0100
> This patch makes it possible to build the CAN Identifier into the kernel, even
> if the CAN support is build as a module.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Why is this so critical that you're asking me to merge this into
the 'net' tree mere days before Linus makes a release?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: sched: enable CAN Identifier to be build into kernel
2012-11-23 10:44 [PATCH] net: sched: enable CAN Identifier to be build into kernel Marc Kleine-Budde
2012-11-23 19:22 ` David Miller
@ 2012-11-25 21:06 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-11-25 21:06 UTC (permalink / raw)
To: mkl; +Cc: netdev, linux-can
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Fri, 23 Nov 2012 11:44:57 +0100
> This patch makes it possible to build the CAN Identifier into the kernel, even
> if the CAN support is build as a module.
>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Applied to net-next, thanks.
> is there a nicer solution to this problem? Or remove the "&& CAN" at all?
I don't see how enabling this with CAN disabled could be
useful, so better to have the dependency there.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-25 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-23 10:44 [PATCH] net: sched: enable CAN Identifier to be build into kernel Marc Kleine-Budde
2012-11-23 19:22 ` David Miller
2012-11-24 12:22 ` Marc Kleine-Budde
2012-11-25 21:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).