From: David Miller <davem@davemloft.net>
To: sathya.perla@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] be2net: fix a possible events_get() race on BE2
Date: Fri, 23 Nov 2012 14:26:21 -0500 (EST) [thread overview]
Message-ID: <20121123.142621.70094578773386257.davem@davemloft.net> (raw)
In-Reply-To: <669f16b7-59f2-4587-af3e-0b6e83f8f68c@CMEXHTCAS2.ad.emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Fri, 23 Nov 2012 15:57:18 +0530
> On BE2 chip, an interrupt being raised even when EQ is in un-armed state has
> been observed a few times. This is not expected and has never been
> observed on BE3/Lancer chips.
>
> As a consequence, be_msix()::events_get() and be_poll()::events_get()
> can race and notify an EQ wrongly causing a CEV UE. The other possible
> side-effect would be traffic stalling because after notifying EQ,
> napi_schedule() is ignored as NAPI is already running.
>
> This patch fixes this issue by counting events only in be_poll().
>
> Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Applied, thanks.
prev parent reply other threads:[~2012-11-23 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 10:27 [PATCH net-next] be2net: fix a possible events_get() race on BE2 Sathya Perla
2012-11-23 19:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121123.142621.70094578773386257.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).