From: David Miller <davem@davemloft.net>
To: dwmw2@infradead.org
Cc: netdev@vger.kernel.org, blogic@openwrt.org, dave.taht@gmail.com,
krzysiek@podlesie.net, chas@cmf.nrl.navy.mil
Subject: Re: [PATCH] atm: br2684: Fix excessive queue bloat
Date: Sun, 25 Nov 2012 16:09:33 -0500 (EST) [thread overview]
Message-ID: <20121125.160933.2139090715980641530.davem@davemloft.net> (raw)
In-Reply-To: <1353715292.26346.237.camel@shinybook.infradead.org>
From: David Woodhouse <dwmw2@infradead.org>
Date: Sat, 24 Nov 2012 00:01:32 +0000
> + /* Allow two packets in the ATM queue. One actually being sent, and one
> + for the ATM 'TX done' handler to send. It shouldn't take long to get
> + the next one from the netdev queue, when we need it. More than that
> + would be bufferbloat. */
Please format this:
/* Like
* this.
*/
and I'll apply this, thanks.
next prev parent reply other threads:[~2012-11-25 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-24 0:01 [PATCH] atm: br2684: Fix excessive queue bloat David Woodhouse
2012-11-25 21:09 ` David Miller [this message]
2012-11-25 21:43 ` Krzysztof Mazur
2012-11-25 22:01 ` David Woodhouse
2012-11-25 23:52 ` Krzysztof Mazur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121125.160933.2139090715980641530.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=blogic@openwrt.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=dave.taht@gmail.com \
--cc=dwmw2@infradead.org \
--cc=krzysiek@podlesie.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).