From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv4: ipmr: various fixes and cleanups
Date: Sun, 25 Nov 2012 16:40:23 -0500 (EST) [thread overview]
Message-ID: <20121125.164023.2066404892904383568.davem@davemloft.net> (raw)
In-Reply-To: <1353861705.30446.675.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 25 Nov 2012 08:41:45 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> 1) ip_mroute_setsockopt() & ip_mroute_getsockopt() should not
> access/set raw_sk(sk)->ipmr_table before making sure the socket
> is a raw socket, and protocol is IGMP
>
> 2) MRT_INIT should return -EINVAL if optlen != sizeof(int), not
> -ENOPROTOOPT
>
> 3) MRT_ASSERT & MRT_PIM should validate optlen
>
> 4) " (v) ? 1 : 0 " can be written as " !!v "
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2012-11-25 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 16:41 [PATCH net-next] ipv4: ipmr: various fixes and cleanups Eric Dumazet
2012-11-25 18:27 ` Joe Perches
2012-11-25 19:13 ` Eric Dumazet
2012-11-25 19:35 ` [PATCH] ipv4/ipmr and ipv6/ip6mr: Convert int mroute_do_<foo> to bool Joe Perches
2012-11-25 21:40 ` David Miller
2012-11-26 4:26 ` [PATCH] ip6mr: Add sizeof verification to MRT6_ASSERT and MT6_PIM Joe Perches
2012-11-26 22:36 ` David Miller
2012-11-25 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121125.164023.2066404892904383568.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).