* [PATCH 1/2] ewrk3: silence GCC warning
@ 2012-11-27 9:47 Paul Bolle
2012-11-28 16:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2012-11-27 9:47 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, richard -rw- weinberger
Building ewrk3.o triggers this GCC warning:
drivers/net/ethernet/dec/ewrk3.c: In function '__check_irq':
drivers/net/ethernet/dec/ewrk3.c:1915:1: warning: return from incompatible pointer type [enabled by default]
This can be trivially fixed by changing the 'irq' parameter from int to
byte (which is an alias for unsigned char for module parameters).
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Only compile tested.
drivers/net/ethernet/dec/ewrk3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/dec/ewrk3.c b/drivers/net/ethernet/dec/ewrk3.c
index 17ae8c6..2ee1c47 100644
--- a/drivers/net/ethernet/dec/ewrk3.c
+++ b/drivers/net/ethernet/dec/ewrk3.c
@@ -1912,7 +1912,7 @@ static int io[MAX_NUM_EWRK3S+1] = { 0x300, 0, };
/* '21' below should really be 'MAX_NUM_EWRK3S' */
module_param_array(io, int, NULL, 0);
-module_param_array(irq, int, NULL, 0);
+module_param_array(irq, byte, NULL, 0);
MODULE_PARM_DESC(io, "EtherWORKS 3 I/O base address(es)");
MODULE_PARM_DESC(irq, "EtherWORKS 3 IRQ number(s)");
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] ewrk3: silence GCC warning
2012-11-27 9:47 [PATCH 1/2] ewrk3: silence GCC warning Paul Bolle
@ 2012-11-28 16:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-11-28 16:35 UTC (permalink / raw)
To: pebolle; +Cc: netdev, linux-kernel, richard.weinberger
From: Paul Bolle <pebolle@tiscali.nl>
Date: Tue, 27 Nov 2012 10:47:17 +0100
> Building ewrk3.o triggers this GCC warning:
> drivers/net/ethernet/dec/ewrk3.c: In function '__check_irq':
> drivers/net/ethernet/dec/ewrk3.c:1915:1: warning: return from incompatible pointer type [enabled by default]
>
> This can be trivially fixed by changing the 'irq' parameter from int to
> byte (which is an alias for unsigned char for module parameters).
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-28 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-27 9:47 [PATCH 1/2] ewrk3: silence GCC warning Paul Bolle
2012-11-28 16:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).