* [patch] atm: forever loop loading ambassador firmware
@ 2012-11-27 17:29 Dan Carpenter
2012-11-28 15:40 ` chas williams - CONTRACTOR
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2012-11-27 17:29 UTC (permalink / raw)
To: Chas Williams, David Woodhouse; +Cc: linux-atm-general, netdev, kernel-janitors
There was a forever loop introduced here when we converted this to
request_firmware() back in 2008.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Spotted in code reading. Untested.
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 89b30f3..ff7bb8a 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -1961,6 +1961,7 @@ static int __devinit ucode_init (loader_block * lb, amb_dev * dev) {
res = loader_verify(lb, dev, rec);
if (res)
break;
+ rec = ihex_next_binrec(rec);
}
release_firmware(fw);
if (!res)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] atm: forever loop loading ambassador firmware
2012-11-27 17:29 [patch] atm: forever loop loading ambassador firmware Dan Carpenter
@ 2012-11-28 15:40 ` chas williams - CONTRACTOR
2012-11-28 16:38 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: chas williams - CONTRACTOR @ 2012-11-28 15:40 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Woodhouse, linux-atm-general, netdev, kernel-janitors
On Tue, 27 Nov 2012 20:29:35 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There was a forever loop introduced here when we converted this to
> request_firmware() back in 2008.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This certainly does seem to be the case.
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
> ---
> Spotted in code reading. Untested.
>
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index 89b30f3..ff7bb8a 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -1961,6 +1961,7 @@ static int __devinit ucode_init (loader_block * lb, amb_dev * dev) {
> res = loader_verify(lb, dev, rec);
> if (res)
> break;
> + rec = ihex_next_binrec(rec);
> }
> release_firmware(fw);
> if (!res)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] atm: forever loop loading ambassador firmware
2012-11-28 15:40 ` chas williams - CONTRACTOR
@ 2012-11-28 16:38 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-11-28 16:38 UTC (permalink / raw)
To: chas; +Cc: dan.carpenter, dwmw2, linux-atm-general, netdev, kernel-janitors
From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Date: Wed, 28 Nov 2012 10:40:44 -0500
> On Tue, 27 Nov 2012 20:29:35 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
>> There was a forever loop introduced here when we converted this to
>> request_firmware() back in 2008.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> This certainly does seem to be the case.
>
> Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-28 16:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-27 17:29 [patch] atm: forever loop loading ambassador firmware Dan Carpenter
2012-11-28 15:40 ` chas williams - CONTRACTOR
2012-11-28 16:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).