From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] atm: forever loop loading ambassador firmware
Date: Wed, 28 Nov 2012 10:40:44 -0500 [thread overview]
Message-ID: <20121128104044.785f1041@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <20121127172935.GB1059@elgon.mountain>
On Tue, 27 Nov 2012 20:29:35 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There was a forever loop introduced here when we converted this to
> request_firmware() back in 2008.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This certainly does seem to be the case.
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
> ---
> Spotted in code reading. Untested.
>
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index 89b30f3..ff7bb8a 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -1961,6 +1961,7 @@ static int __devinit ucode_init (loader_block * lb, amb_dev * dev) {
> res = loader_verify(lb, dev, rec);
> if (res)
> break;
> + rec = ihex_next_binrec(rec);
> }
> release_firmware(fw);
> if (!res)
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-11-28 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 17:29 [patch] atm: forever loop loading ambassador firmware Dan Carpenter
2012-11-28 15:40 ` chas williams - CONTRACTOR [this message]
2012-11-28 16:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121128104044.785f1041@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).