From: Paul Moore <pmoore@redhat.com>
To: netdev@vger.kernel.org, linux-security-module@vger.kernel.org,
selinux@tycho.nsa.gov
Cc: jasowang@redhat.com
Subject: [RFC PATCH 0/2] Fix some multiqueue TUN problems
Date: Thu, 29 Nov 2012 17:06:21 -0500 [thread overview]
Message-ID: <20121129215724.30020.69464.stgit@sifl> (raw)
A relatively short patchset to fix some problems that have arisen from
the multiqueue TUN work. I'm sending this a RFC for now as it changes
the LSM TUN interfaces and therefore crosses a few boundaries,
e.g. SELinux, although it does so only in an effort to restore the
original behavior which was lost in the multiqueue conversion.
I'm not particularly enthused with the idea of passing a void** as a
parameter to security_tun_dev_alloc_security() but the alternatives
would be to move the tun_struct out of tun.c or have the LSM interface
return a pointer (which would require us to return a "fake" non-NULL
pointer when the LSM was disabled) ... neither of these seemed like good
alternatives to me.
I've compiled the code and booted it without drama, but I haven't really
stressed it too much so buyer beware at this point. Comments are always
welcome ...
---
Paul Moore (2):
tun: correctly report an error in tun_flow_init()
tun: fix LSM/SELinux labeling of tun/tap devices
drivers/net/tun.c | 16 ++++++++++----
include/linux/security.h | 37 ++++++++++++++++++++++-----------
security/capability.c | 14 +++++++++---
security/security.c | 22 ++++++++++++-------
security/selinux/hooks.c | 42 +++++++++++++++++++++++--------------
security/selinux/include/objsec.h | 4 ++++
6 files changed, 90 insertions(+), 45 deletions(-)
next reply other threads:[~2012-11-29 22:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 22:06 Paul Moore [this message]
2012-11-29 22:06 ` [RFC PATCH 1/2] tun: correctly report an error in tun_flow_init() Paul Moore
2012-12-05 16:02 ` Paul Moore
2012-12-06 3:35 ` Jason Wang
2012-11-29 22:06 ` [RFC PATCH 2/2] tun: fix LSM/SELinux labeling of tun/tap devices Paul Moore
2012-12-03 10:15 ` Jason Wang
2012-12-03 16:22 ` Paul Moore
2012-12-04 13:24 ` Jason Wang
2012-12-04 15:24 ` Michael S. Tsirkin
2012-12-05 6:17 ` Jason Wang
2012-12-05 11:43 ` Michael S. Tsirkin
2012-12-05 13:45 ` Jason Wang
2012-12-04 16:18 ` Paul Moore
2012-12-04 17:36 ` Michael S. Tsirkin
2012-12-04 18:17 ` Paul Moore
2012-12-05 6:19 ` Jason Wang
2012-12-05 11:44 ` Michael S. Tsirkin
2012-12-05 14:01 ` Jason Wang
2012-12-05 16:00 ` Paul Moore
2012-12-05 5:44 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121129215724.30020.69464.stgit@sifl \
--to=pmoore@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).