netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: zheng.x.li@oracle.com, netdev@vger.kernel.org,
	andy@greyhouse.net, linux-kernel@vger.kernel.org,
	joe.jin@oracle.com
Subject: Re: [PATCH] bonding: rlb mode of bond should not alter ARP originating via bridge
Date: Fri, 30 Nov 2012 12:08:13 -0500 (EST)	[thread overview]
Message-ID: <20121130.120813.1360888707923955813.davem@davemloft.net> (raw)
In-Reply-To: <15005.1354213705@death.nxdomain>

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Thu, 29 Nov 2012 10:28:25 -0800

> Zheng Li <zheng.x.li@oracle.com> wrote:
> 
>>Do not modify or load balance ARP packets passing through balance-alb
>>mode (wherein the ARP did not originate locally, and arrived via a bridge).
>>
>>Modifying pass-through ARP replies causes an incorrect MAC address 
>>to be placed into the ARP packet, rendering peers unable to communicate 
>>with the actual destination from which the ARP reply originated.
>>
>>Load balancing pass-through ARP requests causes an entry to be
>>created for the peer in the rlb table, and bond_alb_monitor will
>>occasionally issue ARP updates to all peers in the table instrucing them
>>as to which MAC address they should communicate with; this occurs when
>>some event sets rx_ntt.  In the bridged case, however, the MAC address
>>used for the update would be the MAC of the slave, not the actual source
>>MAC of the originating destination.  This would render peers unable to
>>communicate with the destinations beyond the bridge.
>>
>>Signed-off-by: Zheng Li <zheng.x.li@oracle.com>
>>Cc: Jay Vosburgh <fubar@us.ibm.com>
>>Cc: Andy Gospodarek <andy@greyhouse.net>
>>Cc: "David S. Miller" <davem@davemloft.net>
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

Applied.

  reply	other threads:[~2012-11-30 17:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28  9:57 [PATCH] bonding: rlb mode of bond should not alter ARP originating via bridge Zheng Li
2012-11-29 18:28 ` Jay Vosburgh
2012-11-30 17:08   ` David Miller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-11-15  9:47 Zheng Li
2012-11-19 23:49 ` David Miller
2012-11-20  1:02 ` Jay Vosburgh
2012-11-20  8:51   ` zheng.li
2012-11-28  0:05     ` Jay Vosburgh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121130.120813.1360888707923955813.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andy@greyhouse.net \
    --cc=fubar@us.ibm.com \
    --cc=joe.jin@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=zheng.x.li@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).