From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: ogerlitz@mellanox.com, oren@mellanox.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 3/3] net/mlx4_en: Set number of rx/tx channels using ethtool
Date: Fri, 30 Nov 2012 12:16:39 -0500 (EST) [thread overview]
Message-ID: <20121130.121639.619094396601908341.davem@davemloft.net> (raw)
In-Reply-To: <1354216903-830-4-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Thu, 29 Nov 2012 21:21:43 +0200
> +static void mlx4_en_get_channels(struct net_device *dev,
> + struct ethtool_channels *channel)
This is not formatted correctly, the argument on the second line
must line up with the first column after the openning "(" on the
previous line.
next prev parent reply other threads:[~2012-11-30 17:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 19:21 [PATCH net-next v1 0/3] mlx4_en: set number of rx/tx channels using ethtool Amir Vadai
2012-11-29 19:21 ` [PATCH net-next v1 1/3] MAINTAINERS: Add Mellanox ethernet driver - mlx4_en Amir Vadai
2012-11-29 19:21 ` [PATCH net-next v1 2/3] net/mlx4_en: Fix TX moderation info loss after set_ringparam is called Amir Vadai
2012-11-29 19:21 ` [PATCH net-next v1 3/3] net/mlx4_en: Set number of rx/tx channels using ethtool Amir Vadai
2012-11-30 17:16 ` David Miller [this message]
2012-11-30 23:58 ` Ben Hutchings
2012-12-01 15:50 ` Or Gerlitz
2012-12-01 16:18 ` Ben Hutchings
2012-12-01 16:25 ` David Miller
2012-12-02 12:23 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130.121639.619094396601908341.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=oren@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).