From: Thomas Graf <tgraf@suug.ch>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Herbert Xu <herbert@gondor.hengli.com.au>,
Stephen Hemminger <shemminger@vyatta.com>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA
Date: Fri, 30 Nov 2012 10:18:14 +0000 [thread overview]
Message-ID: <20121130101814.GD30697@casper.infradead.org> (raw)
In-Reply-To: <1354269514-1863-1-git-send-email-amwang@redhat.com>
On 11/30/12 at 05:58pm, Cong Wang wrote:
> @@ -168,6 +172,8 @@ static const struct nla_policy ifla_brport_policy[IFLA_BRPORT_MAX + 1] = {
> [IFLA_BRPORT_MODE] = { .type = NLA_U8 },
> [IFLA_BRPORT_GUARD] = { .type = NLA_U8 },
> [IFLA_BRPORT_PROTECT] = { .type = NLA_U8 },
> + [IFLA_BRPORT_NO] = { .type = NLA_U16 },
> + [IFLA_BRPORT_ID] = { .type = NLA_U16 },
> };
>
> /* Change the state of the port and notify spanning tree */
I missed this in the first round. Not much of a point in adding policy
entries if the attributes are read-only as in this case.
next prev parent reply other threads:[~2012-11-30 10:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 9:58 [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA Cong Wang
2012-11-30 9:58 ` [PATCH net-next v1 2/2] bridge: export multicast database via netlink Cong Wang
2012-11-30 11:26 ` Thomas Graf
2012-11-30 15:00 ` Cong Wang
2012-11-30 15:27 ` Thomas Graf
2012-12-01 3:56 ` Cong Wang
2012-11-30 9:58 ` [PATCH iproute2 v1] Add mdb command to bridge Cong Wang
2012-11-30 10:54 ` Thomas Graf
2012-11-30 14:50 ` Cong Wang
2012-11-30 10:18 ` Thomas Graf [this message]
2012-11-30 14:51 ` [PATCH net-next v1 1/2] bridge: export port_no and port_id via IFA_INFO_DATA Cong Wang
2012-11-30 15:52 ` Stephen Hemminger
2012-12-01 3:53 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130101814.GD30697@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=amwang@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).