From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org, tgraf@suug.ch,
tore@fud.no
Subject: Re: [PATCH] ipv6: unify logic evaluating inet6_dev's accept_ra property
Date: Fri, 30 Nov 2012 21:51:13 +0200 [thread overview]
Message-ID: <20121130215113.7a81bc16.shmulik.ladkani@gmail.com> (raw)
In-Reply-To: <20121130.120943.1397811156693287841.davem@davemloft.net>
Hi,
On Fri, 30 Nov 2012 12:09:43 -0500 (EST) David Miller <davem@davemloft.net> wrote:
> From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> Date: Thu, 29 Nov 2012 11:26:19 +0200
>
> > + /*
> > + * If forwarding is enabled, RA are not accepted unless the special
> > + * hybrid mode (accept_ra=2) is enabled.
> > + */
>
> Please format this comment correctly, in the networking we use
> the style:
>
> /* That looks
> * like this.
> */
>
> /*
> * Not
> * like this.
> */
>
> Thanks.
Ok. Will amend shortly.
BTW the "Not like this" style has many occurrences in net/ipv6.
One of which was the comment relocated by my patch :-)
Regards,
Shmulik
next prev parent reply other threads:[~2012-11-30 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 9:26 [PATCH] ipv6: unify logic evaluating inet6_dev's accept_ra property Shmulik Ladkani
2012-11-30 17:09 ` David Miller
2012-11-30 19:51 ` Shmulik Ladkani [this message]
2012-11-30 20:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130215113.7a81bc16.shmulik.ladkani@gmail.com \
--to=shmulik.ladkani@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tore@fud.no \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).