* [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion
@ 2012-12-03 9:45 Sachin Kamat
2012-12-03 18:46 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2012-12-03 9:45 UTC (permalink / raw)
To: netdev; +Cc: thomas.petazzoni, sachin.kamat, patches
linux/version.h inclusion is not necessary.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/net/ethernet/marvell/mvneta.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 3f8086b..a1e0e9f 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -12,7 +12,6 @@
*/
#include <linux/kernel.h>
-#include <linux/version.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
#include <linux/platform_device.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion
2012-12-03 9:45 [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion Sachin Kamat
@ 2012-12-03 18:46 ` David Miller
2012-12-03 18:58 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2012-12-03 18:46 UTC (permalink / raw)
To: sachin.kamat; +Cc: netdev, thomas.petazzoni, patches
From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Mon, 3 Dec 2012 15:15:28 +0530
> linux/version.h inclusion is not necessary.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: David S. Miller <davem@davemloft.net>
I hope the mvneta folks will pick this up and apply it where it
needs to be as the mvneta driver isn't in the net-next tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion
2012-12-03 18:46 ` David Miller
@ 2012-12-03 18:58 ` Thomas Petazzoni
2013-01-17 3:00 ` Sachin Kamat
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2012-12-03 18:58 UTC (permalink / raw)
To: David Miller; +Cc: sachin.kamat, netdev, patches
Dear David Miller,
On Mon, 03 Dec 2012 13:46:20 -0500 (EST), David Miller wrote:
> From: Sachin Kamat <sachin.kamat@linaro.org>
> Date: Mon, 3 Dec 2012 15:15:28 +0530
>
> > linux/version.h inclusion is not necessary.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>
> Acked-by: David S. Miller <davem@davemloft.net>
>
> I hope the mvneta folks will pick this up and apply it where it
> needs to be as the mvneta driver isn't in the net-next tree.
Yes, I will pick it up, and send a pull request to the Marvell
maintainers. I have other mvneta fixes that I'll send together with
this one.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion
2012-12-03 18:58 ` Thomas Petazzoni
@ 2013-01-17 3:00 ` Sachin Kamat
0 siblings, 0 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-01-17 3:00 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: netdev
Hi Thomas,
On 4 December 2012 00:28, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear David Miller,
>
> On Mon, 03 Dec 2012 13:46:20 -0500 (EST), David Miller wrote:
>> From: Sachin Kamat <sachin.kamat@linaro.org>
>> Date: Mon, 3 Dec 2012 15:15:28 +0530
>>
>> > linux/version.h inclusion is not necessary.
>> >
>> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Acked-by: David S. Miller <davem@davemloft.net>
>>
>> I hope the mvneta folks will pick this up and apply it where it
>> needs to be as the mvneta driver isn't in the net-next tree.
>
> Yes, I will pick it up, and send a pull request to the Marvell
> maintainers. I have other mvneta fixes that I'll send together with
> this one.
Can you please share the git repo link where this patch is lined up ATM?
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-17 3:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 9:45 [PATCH 1/1] net: mvneta: Remove unneeded version.h header inclusion Sachin Kamat
2012-12-03 18:46 ` David Miller
2012-12-03 18:58 ` Thomas Petazzoni
2013-01-17 3:00 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).