From: David Miller <davem@davemloft.net>
To: jogreene@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFT PATCH] 8139cp: properly support change of MTU values [v2]
Date: Mon, 03 Dec 2012 13:52:00 -0500 (EST) [thread overview]
Message-ID: <20121203.135200.1242505353532930826.davem@davemloft.net> (raw)
In-Reply-To: <1354551573-23721-1-git-send-email-jogreene@redhat.com>
From: John Greene <jogreene@redhat.com>
Date: Mon, 3 Dec 2012 11:19:33 -0500
> The 8139cp driver has a change_mtu function that has not been
> enabled since the dawn of the git repository. However, the
> generic eth_change_mtu is not used in its place, so that
> invalid MTU values can be set on the interface.
>
> Original patch salvages the broken code for the single case of
> setting the MTU while the interface is down, which is safe
> and also includes the range check. Now enhanced to support up
> or down interface.
>
> v2: fix case where rxbufsz isn't changed in the up state case
>
> Original patch from
> http://lkml.indiana.edu/hypermail/linux/kernel/1202.2/00770.html
>
> Testing: has been test on virtual 8139cp setup without issue,
> have no access real hardware 8139cp, need testing help.
>
> Signed-off-by: "John Greene" <jogreene@redhat.com>
I've applied this to net-next, if it triggers any problems we have
some time to work it out before 3.8 is released.
next prev parent reply other threads:[~2012-12-03 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 16:19 [RFT PATCH] 8139cp: properly support change of MTU values [v2] John Greene
2012-12-03 18:52 ` David Miller [this message]
2012-12-03 20:46 ` Francois Romieu
2012-12-04 15:44 ` David Woodhouse
2012-12-04 19:04 ` John Greene
2012-12-06 1:34 ` David Woodhouse
2012-12-05 19:41 ` John Greene
2012-12-13 19:56 ` John Greene
2012-12-13 22:36 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203.135200.1242505353532930826.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).