From: David Miller <davem@davemloft.net>
To: LinoSanfilippo@gmx.de
Cc: shemminger@vyatta.com, mlindner@marvell.com, netdev@vger.kernel.org
Subject: Re: sky2: fix cleanup sequence in probe() function
Date: Mon, 03 Dec 2012 13:53:04 -0500 (EST) [thread overview]
Message-ID: <20121203.135304.402769242967325322.davem@davemloft.net> (raw)
In-Reply-To: <20121201123928.GA3914@neptun>
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Date: Sat, 1 Dec 2012 13:39:28 +0100
> The cleanup sequence in sky2_probe() that is called in case of an error is
> mixed up in different places:
>
> - pci_disable_device() is not called in each case the device has been enabled
> before
>
> - same for pci_disable_msi(): test_msi() may return with an error != EOPNOTSUPP
> (due to failure of request_irq()). In that case msi is not disabled
>
> - also failure of register_netdev() does not disable msi
>
> This patch fixes the concerning parts.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
This looks clearly correct to me, so I've applied it to net-next, thanks.
prev parent reply other threads:[~2012-12-03 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-01 12:39 sky2: fix cleanup sequence in probe() function Lino Sanfilippo
2012-12-03 18:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203.135304.402769242967325322.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=LinoSanfilippo@gmx.de \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).