From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [patch net-next] net: call notifiers for mtu change even if iface is not up Date: Mon, 3 Dec 2012 09:18:23 -0500 Message-ID: <20121203141823.GA21816@hmsreliant.think-freely.org> References: <1354533392-9308-1-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, bhutchings@solarflare.com, psimerda@redhat.com To: Jiri Pirko Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:45312 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754745Ab2LCOSg (ORCPT ); Mon, 3 Dec 2012 09:18:36 -0500 Content-Disposition: inline In-Reply-To: <1354533392-9308-1-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Dec 03, 2012 at 12:16:32PM +0100, Jiri Pirko wrote: > Do the same thing as in set mac. Call notifiers every time. > > Signed-off-by: Jiri Pirko > --- > net/core/dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/dev.c b/net/core/dev.c > index 2f94df2..0685a72 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -4971,7 +4971,7 @@ int dev_set_mtu(struct net_device *dev, int new_mtu) > else > dev->mtu = new_mtu; > > - if (!err && dev->flags & IFF_UP) > + if (!err) > call_netdevice_notifiers(NETDEV_CHANGEMTU, dev); > return err; > } I'm not opposed to this change, but is there something that it expressly fixes? While it doesn't hurt to send around mtu change events, one would presume that listeners would pick up mtu changes when the NETDEV_UP event went' around. Neil