From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net/macb: increase RX buffer size for GEM Date: Tue, 04 Dec 2012 13:22:27 -0500 (EST) Message-ID: <20121204.132227.1430662061932892582.davem@davemloft.net> References: <1354536943-6356-1-git-send-email-nicolas.ferre@atmel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, manabian@gmail.com, plagnioj@jcrosoft.com To: nicolas.ferre@atmel.com Return-path: In-Reply-To: <1354536943-6356-1-git-send-email-nicolas.ferre@atmel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Nicolas Ferre Date: Mon, 3 Dec 2012 13:15:43 +0100 > Macb Ethernet controller requires a RX buffer of 128 bytes. It is > highly sub-optimal for Gigabit-capable GEM that is able to use > a bigger DMA buffer. Change this constant and associated macros > with data stored in the private structure. > I also kept the result of buffers per page calculation to lower the > impact of this move to a variable rx buffer size on rx hot path. > RX DMA buffer size has to be multiple of 64 bytes as indicated in > DMA Configuration Register specification. > > Signed-off-by: Nicolas Ferre This looks like it will waste a couple hundred bytes for 1500 MTU frames, am I right?