From: David Miller <davem@davemloft.net>
To: dlstevens@us.ibm.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: avoid taking locks at socket dismantle
Date: Wed, 05 Dec 2012 16:21:50 -0500 (EST) [thread overview]
Message-ID: <20121205.162150.1116416856345924607.davem@davemloft.net> (raw)
In-Reply-To: <OF525F8BC1.196D90F1-ON85257ACB.0073BE61-85257ACB.007403D3@us.ibm.com>
From: David Stevens <dlstevens@us.ibm.com>
Date: Wed, 5 Dec 2012 16:07:16 -0500
>> From: Eric Dumazet <edumazet@google.com>
>>
>> ipv6_sock_mc_close() is called for ipv6 sockets at close time, and most
>> of them don't use multicast.
>>
>> Add a test to avoid contention on a shared spinlock.
>>
>> Same heuristic applies for ipv6_sock_ac_close(), to avoid contention
>> on a shared rwlock.
>
> What prevents a different thread from racing with the
> tests for NULL on these?
The socket is being torn apart, which means that operations on it's
FD are no longer possible, which means that no other thread can add
entries to these lists.
next prev parent reply other threads:[~2012-12-05 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 19:18 [PATCH net-next] ipv6: avoid taking locks at socket dismantle Eric Dumazet
2012-12-05 21:07 ` David Stevens
2012-12-05 21:21 ` David Miller [this message]
2012-12-05 21:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205.162150.1116416856345924607.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).